From bba85dc9b0dd7631c08318d30bc9d8add9ca39e8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gast=C3=B3n=20Fournier?= <gaston@getunleash.io>
Date: Wed, 2 Apr 2025 11:59:47 +0200
Subject: [PATCH] chore: fix coverage tests (#9674)

Coverage has been failing for a while:
https://github.com/Unleash/unleash/actions/workflows/build_coverage.yaml
It looks related to minimatch version:
```
     TypeError: /home/runner/work/unleash/unleash/src/lib/util/isDefined.ts: minimatch is not a function
```

Removing `"minimatch": "^10.0.0",` resolution seems to fix it, but it
will likely introduce a security vulnerability error

Works on my machine results:
```shell
Test Suites: 345 passed, 345 total
Tests:       3 skipped, 3119 passed, 3122 total
Snapshots:   110 passed, 110 total
Time:        218.532 s
```
---
 .github/workflows/build_coverage.yaml |  6 +++--
 package.json                          |  3 +--
 yarn.lock                             | 38 ++++++++++++++++++++++-----
 3 files changed, 37 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/build_coverage.yaml b/.github/workflows/build_coverage.yaml
index 811faaa9a7..8061dd19ee 100644
--- a/.github/workflows/build_coverage.yaml
+++ b/.github/workflows/build_coverage.yaml
@@ -41,8 +41,10 @@ jobs:
           cache: 'yarn'
       - name: Enable corepack
         run: corepack enable
-      - run: yarn
-      - run: yarn build:frontend:if-needed
+      - run: yarn install --immutable
+        env:
+          YARN_ENABLE_SCRIPTS: false
+      - run: yarn build:frontend
       - run: yarn run test:coverage
         env:
           CI: true
diff --git a/package.json b/package.json
index 11b56cd83b..43e20c5e2d 100644
--- a/package.json
+++ b/package.json
@@ -203,7 +203,7 @@
     "@types/uuid": "9.0.8",
     "concurrently": "^9.0.0",
     "copyfiles": "2.4.1",
-    "coveralls": "3.1.1",
+    "coveralls": "^3.1.1",
     "del-cli": "5.1.0",
     "faker": "5.5.3",
     "fast-check": "3.23.2",
@@ -233,7 +233,6 @@
     "json-schema": "^0.4.0",
     "ip": "^2.0.1",
     "tar": "7.4.3",
-    "minimatch": "^10.0.0",
     "semver": "^7.6.2",
     "tough-cookie": "4.1.4",
     "@wesleytodd/openapi/path-to-regexp": "6.3.0",
diff --git a/yarn.lock b/yarn.lock
index 13862a42ce..b81ff68d49 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -2763,6 +2763,16 @@ __metadata:
   languageName: node
   linkType: hard
 
+"brace-expansion@npm:^1.1.7":
+  version: 1.1.11
+  resolution: "brace-expansion@npm:1.1.11"
+  dependencies:
+    balanced-match: "npm:^1.0.0"
+    concat-map: "npm:0.0.1"
+  checksum: 10c0/695a56cd058096a7cb71fb09d9d6a7070113c7be516699ed361317aca2ec169f618e28b8af352e02ab4233fb54eb0168460a40dc320bab0034b36ab59aaad668
+  languageName: node
+  linkType: hard
+
 "brace-expansion@npm:^2.0.1":
   version: 2.0.1
   resolution: "brace-expansion@npm:2.0.1"
@@ -3198,6 +3208,13 @@ __metadata:
   languageName: node
   linkType: hard
 
+"concat-map@npm:0.0.1":
+  version: 0.0.1
+  resolution: "concat-map@npm:0.0.1"
+  checksum: 10c0/c996b1cfdf95b6c90fee4dae37e332c8b6eb7d106430c17d538034c0ad9a1630cb194d2ab37293b1bdd4d779494beee7786d586a50bd9376fd6f7bcc2bd4c98f
+  languageName: node
+  linkType: hard
+
 "concurrently@npm:^9.0.0":
   version: 9.1.2
   resolution: "concurrently@npm:9.1.2"
@@ -3364,7 +3381,7 @@ __metadata:
   languageName: node
   linkType: hard
 
-"coveralls@npm:3.1.1":
+"coveralls@npm:^3.1.1":
   version: 3.1.1
   resolution: "coveralls@npm:3.1.1"
   dependencies:
@@ -6677,12 +6694,21 @@ __metadata:
   languageName: node
   linkType: hard
 
-"minimatch@npm:^10.0.0":
-  version: 10.0.1
-  resolution: "minimatch@npm:10.0.1"
+"minimatch@npm:^3.0.3, minimatch@npm:^3.0.4, minimatch@npm:^3.1.1":
+  version: 3.1.2
+  resolution: "minimatch@npm:3.1.2"
+  dependencies:
+    brace-expansion: "npm:^1.1.7"
+  checksum: 10c0/0262810a8fc2e72cca45d6fd86bd349eee435eb95ac6aa45c9ea2180e7ee875ef44c32b55b5973ceabe95ea12682f6e3725cbb63d7a2d1da3ae1163c8b210311
+  languageName: node
+  linkType: hard
+
+"minimatch@npm:^9.0.1, minimatch@npm:^9.0.4":
+  version: 9.0.5
+  resolution: "minimatch@npm:9.0.5"
   dependencies:
     brace-expansion: "npm:^2.0.1"
-  checksum: 10c0/e6c29a81fe83e1877ad51348306be2e8aeca18c88fdee7a99df44322314279e15799e41d7cb274e4e8bb0b451a3bc622d6182e157dfa1717d6cda75e9cd8cd5d
+  checksum: 10c0/de96cf5e35bdf0eab3e2c853522f98ffbe9a36c37797778d2665231ec1f20a9447a7e567cb640901f89e4daaa95ae5d70c65a9e8aa2bb0019b6facbc3c0575ed
   languageName: node
   linkType: hard
 
@@ -9372,7 +9398,7 @@ __metadata:
     cookie-session: "npm:^2.0.0-rc.1"
     copyfiles: "npm:2.4.1"
     cors: "npm:^2.8.5"
-    coveralls: "npm:3.1.1"
+    coveralls: "npm:^3.1.1"
     date-fns: "npm:^2.30.0"
     db-migrate: "npm:0.11.14"
     db-migrate-pg: "npm:1.5.2"