Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

refactor: sessions for user without error (#8742)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2024-11-13 16:37:05 +01:00 committed by GitHub
parent fecf57c467
commit bcbbd5c3e6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/db/session-store.ts
View File

@ -43,9 +43,7 @@ export default class SessionStore implements ISessionStore {
if (rows && rows.length > 0) { if (rows && rows.length > 0) {
return rows.map(this.rowToSession); return rows.map(this.rowToSession);
} }
throw new NotFoundError( return [];
`Could not find sessions for user with id ${userId}`,
);
} }
async get(sid: string): Promise<ISession> { async get(sid: string): Promise<ISession> {

7
src/lib/services/session-service.ts
View File

@ -37,11 +37,8 @@ export default class SessionService {
userId: number, userId: number,
maxSessions: number, maxSessions: number,
): Promise<void> { ): Promise<void> {
let userSessions: ISession[] = []; const userSessions: ISession[] =
try { await this.sessionStore.getSessionsForUser(userId);
// this method may throw errors when no session
userSessions = await this.sessionStore.getSessionsForUser(userId);
} catch (e) {}
const newestFirst = userSessions.sort((a, b) => const newestFirst = userSessions.sort((a, b) =>
compareDesc(a.createdAt, b.createdAt), compareDesc(a.createdAt, b.createdAt),
); );

5
src/test/e2e/services/session-service.e2e.test.ts
View File

@ -95,9 +95,8 @@ test('Can delete sessions by user', async () => {
const sessions = await sessionService.getActiveSessions(); const sessions = await sessionService.getActiveSessions();
expect(sessions.length).toBe(2); expect(sessions.length).toBe(2);
await sessionService.deleteSessionsForUser(2); await sessionService.deleteSessionsForUser(2);
await expect(async () => { const noSessions = await sessionService.getSessionsForUser(2);
await sessionService.getSessionsForUser(2); expect(noSessions.length).toBe(0);
}).rejects.toThrow(NotFoundError);
}); });
test('Can delete session by sid', async () => { test('Can delete session by sid', async () => {

5
src/test/e2e/services/user-service.e2e.test.ts
View File

@ -357,9 +357,8 @@ test("deleting a user should delete the user's sessions", async () => {
const userSessions = await sessionService.getSessionsForUser(user.id); const userSessions = await sessionService.getSessionsForUser(user.id);
expect(userSessions.length).toBe(1); expect(userSessions.length).toBe(1);
await userService.deleteUser(user.id, TEST_AUDIT_USER); await userService.deleteUser(user.id, TEST_AUDIT_USER);
await expect(async () => const noSessions = await sessionService.getSessionsForUser(user.id);
sessionService.getSessionsForUser(user.id), expect(noSessions.length).toBe(0);
).rejects.toThrow(NotFoundError);
}); });
test('updating a user without an email should not strip the email', async () => { test('updating a user without an email should not strip the email', async () => {