Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-03-27 00:19:39 +01:00
Code Issues Projects Releases Wiki Activity

fix: avoid duplicate unselected filters (#5633)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2023-12-13 13:01:55 +01:00 committed by GitHub
parent c552f3ae72
commit bcf0e6b7a3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
frontend/src/component/filter/Filters.tsx
View File

@ -63,29 +63,32 @@ export const Filters: VFC<IFilterProps> = ({
firstArray: string[], firstArray: string[],
secondArray: string[], secondArray: string[],
): string[] => { ): string[] => {
const resultArray: string[] = [...firstArray];
const elementsSet = new Set(firstArray); const elementsSet = new Set(firstArray);
secondArray.forEach((element) => { secondArray.forEach((element) => {
if (!elementsSet.has(element)) { if (!elementsSet.has(element)) {
firstArray.push(element); resultArray.push(element);
} }
}); });
return firstArray; return resultArray;
}; };
useEffect(() => { useEffect(() => {
const newSelectedFilters = availableFilters const newSelectedFilters = availableFilters
.filter((field) => Boolean(state[field.filterKey])) .filter((field) => Boolean(state[field.filterKey]))
.map((field) => field.label); .map((field) => field.label);
const allSelectedFilters = mergeArraysKeepingOrder(
selectedFilters,
newSelectedFilters,
);
setSelectedFilters(allSelectedFilters);
const newUnselectedFilters = availableFilters const newUnselectedFilters = availableFilters
.filter((field) => !state[field.filterKey]) .filter((item) => !allSelectedFilters.includes(item.label))
.map((field) => field.label) .map((field) => field.label)
.sort(); .sort();
setSelectedFilters(
mergeArraysKeepingOrder(selectedFilters, newSelectedFilters),
);
setUnselectedFilters(newUnselectedFilters); setUnselectedFilters(newUnselectedFilters);
}, [JSON.stringify(state), JSON.stringify(availableFilters)]); }, [JSON.stringify(state), JSON.stringify(availableFilters)]);