Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-25 00:07:47 +01:00
Code Issues Projects Releases Wiki Activity

fix: improve drag behaviour when using handle (#2407)

Browse Source 
Fixes a small bug that caused the item to be draggable when clicking
outside of the handle, when using a handle. Basically resets the
draggable state when (re)entering the container.
This commit is contained in:
Nuno Góis 2022-11-14 08:25:20 +00:00 committed by GitHub
parent 29da625195
commit bd686eb246
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/src/hooks/useDragItem.ts
View File

@ -74,6 +74,9 @@ const addEventListeners = (
handleEl.addEventListener('mouseenter', onMouseEnter); handleEl.addEventListener('mouseenter', onMouseEnter);
handleEl.addEventListener('mouseleave', onMouseLeave); handleEl.addEventListener('mouseleave', onMouseLeave);
if (handle) {
el.addEventListener('mouseenter', onMouseLeave);
}
el.addEventListener('dragstart', onDragStart); el.addEventListener('dragstart', onDragStart);
el.addEventListener('dragenter', onDragEnter); el.addEventListener('dragenter', onDragEnter);
el.addEventListener('dragover', onDragOver); el.addEventListener('dragover', onDragOver);
@ -82,6 +85,9 @@ const addEventListeners = (
return () => { return () => {
handleEl.removeEventListener('mouseenter', onMouseEnter); handleEl.removeEventListener('mouseenter', onMouseEnter);
handleEl.removeEventListener('mouseleave', onMouseLeave); handleEl.removeEventListener('mouseleave', onMouseLeave);
if (handle) {
el.removeEventListener('mouseenter', onMouseLeave);
}
el.removeEventListener('dragstart', onDragStart); el.removeEventListener('dragstart', onDragStart);
el.removeEventListener('dragenter', onDragEnter); el.removeEventListener('dragenter', onDragEnter);
el.removeEventListener('dragover', onDragOver); el.removeEventListener('dragover', onDragOver);