Remove favorites feature flag (#2722)

frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.tsx

@@ -90,8 +90,6 @@ export const FeatureToggleListTable: VFC = () => {
 
     const columns = useMemo(
         () => [
-            ...(uiConfig?.flags?.favorites
-                ? [
             {
                 Header: (
                     <FavoriteIconHeader
@@ -109,8 +107,6 @@ export const FeatureToggleListTable: VFC = () => {
                 maxWidth: 50,
                 disableSortBy: true,
             },
-                  ]
-                : []),
             {
                 Header: 'Seen',
                 accessor: 'lastSeenAt',
@@ -179,7 +175,7 @@ export const FeatureToggleListTable: VFC = () => {
                 searchable: true,
             },
         ],
-        [isFavoritesPinned, uiConfig?.flags?.favorites]
+        [isFavoritesPinned]
     );
 
     const {

frontend/src/component/feature/FeatureView/FeatureView.tsx

@@ -115,17 +115,10 @@ export const FeatureView = () => {
                         <div className={styles.header}>
                             <div className={styles.innerContainer}>
                                 <div className={styles.toggleInfoContainer}>
-                                    <ConditionallyRender
-                                        condition={Boolean(
-                                            uiConfig?.flags?.favorites
-                                        )}
-                                        show={() => (
                                     <FavoriteIconButton
                                         onClick={onFavorite}
                                         isFavorite={feature?.favorite}
                                     />
-                                        )}
-                                    />
                                     <h1
                                         className={styles.featureViewHeader}
                                         data-loading

frontend/src/component/project/Project/Project.tsx

@@ -156,15 +156,10 @@ const Project = () => {
                 <div className={styles.innerContainer}>
                     <StyledTopRow>
                         <StyledDiv>
-                            <ConditionallyRender
-                                condition={Boolean(uiConfig?.flags?.favorites)}
-                                show={() => (
                             <StyledFavoriteIconButton
                                 onClick={onFavorite}
                                 isFavorite={project?.favorite}
                             />
-                                )}
-                            />
                             <h2 className={styles.title}>
                                 <StyledName data-loading>
                                     {projectName}

frontend/src/component/project/Project/ProjectFeatureToggles/ProjectFeatureToggles.tsx

@@ -193,8 +193,6 @@ export const ProjectFeatureToggles = ({
 
     const columns = useMemo(
         () => [
-            ...(uiConfig?.flags?.favorites
-                ? [
             {
                 id: 'favorite',
                 Header: (
@@ -213,8 +211,6 @@ export const ProjectFeatureToggles = ({
                 maxWidth: 50,
                 disableSortBy: true,
             },
-                  ]
-                : []),
             {
                 Header: 'Seen',
                 accessor: 'lastSeenAt',
@@ -303,7 +299,7 @@ export const ProjectFeatureToggles = ({
                 disableSortBy: true,
             },
         ],
-        [projectId, environments, loading, onToggle, uiConfig?.flags?.favorites]
+        [projectId, environments, loading, onToggle]
     );
 
     const [searchValue, setSearchValue] = useState(

frontend/src/component/project/ProjectCard/ProjectCard.tsx

@@ -69,17 +69,12 @@ export const ProjectCard = ({
     return (
         <Card className={classes.projectCard} onMouseEnter={onHover}>
             <div className={classes.header} data-loading>
-                <ConditionallyRender
-                    condition={Boolean(uiConfig?.flags?.favorites)}
-                    show={() => (
                 <FavoriteIconButton
                     onClick={onFavorite}
                     isFavorite={isFavorite}
                     size="medium"
                     sx={{ ml: -1 }}
                 />
-                    )}
-                />
                 <h2 className={classes.title}>{name}</h2>
 
                 <PermissionIconButton

frontend/src/interfaces/uiConfig.ts

@@ -44,7 +44,6 @@ export interface IFlags {
     embedProxyFrontend?: boolean;
     changeRequests?: boolean;
     variantsPerEnvironment?: boolean;
-    favorites?: boolean;
     networkView?: boolean;
     maintenance?: boolean;
 }

src/lib/__snapshots__/create-config.test.ts.snap

@@ -74,7 +74,6 @@ exports[`should create default config 1`] = `
       "changeRequests": false,
       "embedProxy": true,
       "embedProxyFrontend": true,
-      "favorites": false,
       "maintenance": false,
       "maintenanceMode": false,
       "networkView": false,
@@ -92,7 +91,6 @@ exports[`should create default config 1`] = `
       "changeRequests": false,
       "embedProxy": true,
       "embedProxyFrontend": true,
-      "favorites": false,
       "maintenance": false,
       "maintenanceMode": false,
       "networkView": false,

src/lib/db/feature-strategy-store.ts

@@ -259,7 +259,7 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
             .modify(FeatureToggleStore.filterByArchived, archived);
 
         let selectColumns = ['features_view.*'] as (string | Raw<any>)[];
-        if (userId && this.flagResolver.isEnabled('favorites')) {
+        if (userId) {
             query = query.leftJoin(`favorite_features`, function () {
                 this.on(
                     'favorite_features.feature',
@@ -460,7 +460,7 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
             'ft.tag_type as tag_type',
         ] as (string | Raw<any>)[];
 
-        if (userId && this.flagResolver.isEnabled('favorites')) {
+        if (userId) {
             query = query.leftJoin(`favorite_features`, function () {
                 this.on('favorite_features.feature', 'features.name').andOnVal(
                     'favorite_features.user_id',

src/lib/db/feature-toggle-client-store.ts

@@ -146,7 +146,7 @@ export default class FeatureToggleClientStore
                 'ft.tag_type as tag_type',
             ];
 
-            if (userId && this.flagResolver.isEnabled('favorites')) {
+            if (userId) {
                 query = query.leftJoin(`favorite_features`, function () {
                     this.on(
                         'favorite_features.feature',

src/lib/db/project-store.ts

@@ -100,7 +100,7 @@ class ProjectStore implements IProjectStore {
 
         let groupByColumns = ['projects.id'];
 
-        if (userId && this.flagResolver.isEnabled('favorites')) {
+        if (userId) {
             projects = projects.leftJoin(`favorite_projects`, function () {
                 this.on('favorite_projects.project', 'projects.id').andOnVal(
                     'favorite_projects.user_id',

src/lib/routes/admin-api/index.ts

@@ -27,7 +27,6 @@ import PatController from './user/pat';
 import { PublicSignupController } from './public-signup';
 import InstanceAdminController from './instance-admin';
 import FavoritesController from './favorites';
-import { conditionalMiddleware } from '../../middleware';
 import MaintenanceController from './maintenance';
 
 class AdminApi extends Controller {
@@ -120,10 +119,7 @@ class AdminApi extends Controller {
         );
         this.app.use(
             `/projects`,
-            conditionalMiddleware(
-                () => config.flagResolver.isEnabled('favorites'),
             new FavoritesController(config, services).router,
-            ),
         );
 
         this.app.use(

src/lib/types/experimental.ts

@@ -35,10 +35,6 @@ const flags = {
         process.env.UNLEASH_EXPERIMENTAL_VARIANTS_PER_ENVIRONMENT,
         false,
     ),
-    favorites: parseEnvVarBoolean(
-        process.env.UNLEASH_EXPERIMENTAL_FAVORITES,
-        false,
-    ),
     networkView: parseEnvVarBoolean(
         process.env.UNLEASH_EXPERIMENTAL_NETWORK_VIEW,
         false,

src/server-dev.ts

@@ -40,7 +40,6 @@ process.nextTick(async () => {
                         anonymiseEventLog: false,
                         responseTimeWithAppName: true,
                         changeRequests: true,
-                        favorites: true,
                         variantsPerEnvironment: true,
                     },
                 },

src/test/config/test-config.ts

@@ -29,7 +29,6 @@ export function createTestConfig(config?: IUnleashOptions): IUnleashConfig {
                 batchMetrics: true,
                 changeRequests: true,
                 variantsPerEnvironment: true,
-                favorites: true,
             },
         },
     };

src/test/e2e/api/openapi/__snapshots__/openapi.e2e.test.ts.snap

@@ -5333,6 +5333,50 @@ If the provided project does not exist, the list of events will be empty.",
         ],
       },
     },
+    "/api/admin/projects/{projectId}/favorites": {
+      "delete": {
+        "operationId": "removeFavoriteProject",
+        "parameters": [
+          {
+            "in": "path",
+            "name": "projectId",
+            "required": true,
+            "schema": {
+              "type": "string",
+            },
+          },
+        ],
+        "responses": {
+          "200": {
+            "description": "This response has no body.",
+          },
+        },
+        "tags": [
+          "Features",
+        ],
+      },
+      "post": {
+        "operationId": "addFavoriteProject",
+        "parameters": [
+          {
+            "in": "path",
+            "name": "projectId",
+            "required": true,
+            "schema": {
+              "type": "string",
+            },
+          },
+        ],
+        "responses": {
+          "200": {
+            "description": "This response has no body.",
+          },
+        },
+        "tags": [
+          "Features",
+        ],
+      },
+    },
     "/api/admin/projects/{projectId}/features": {
       "get": {
         "operationId": "getFeatures",
@@ -6304,6 +6348,66 @@ If the provided project does not exist, the list of events will be empty.",
         ],
       },
     },
+    "/api/admin/projects/{projectId}/features/{featureName}/favorites": {
+      "delete": {
+        "operationId": "removeFavoriteFeature",
+        "parameters": [
+          {
+            "in": "path",
+            "name": "projectId",
+            "required": true,
+            "schema": {
+              "type": "string",
+            },
+          },
+          {
+            "in": "path",
+            "name": "featureName",
+            "required": true,
+            "schema": {
+              "type": "string",
+            },
+          },
+        ],
+        "responses": {
+          "200": {
+            "description": "This response has no body.",
+          },
+        },
+        "tags": [
+          "Features",
+        ],
+      },
+      "post": {
+        "operationId": "addFavoriteFeature",
+        "parameters": [
+          {
+            "in": "path",
+            "name": "projectId",
+            "required": true,
+            "schema": {
+              "type": "string",
+            },
+          },
+          {
+            "in": "path",
+            "name": "featureName",
+            "required": true,
+            "schema": {
+              "type": "string",
+            },
+          },
+        ],
+        "responses": {
+          "200": {
+            "description": "This response has no body.",
+          },
+        },
+        "tags": [
+          "Features",
+        ],
+      },
+    },
     "/api/admin/projects/{projectId}/features/{featureName}/variants": {
       "get": {
         "operationId": "getFeatureVariants",