Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-08-04 13:48:56 +02:00
Code Issues Projects Releases Wiki Activity

chore: limit requested approver count to 10 (#10279)

Browse Source
This commit is contained in:
David Leek 2025-07-03 09:25:58 +02:00 committed by GitHub
parent 48efcefba7
commit bed467520d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/src/component/changeRequest/ChangeRequestOverview/ChangeRequestRequestedApprovers/ChangeRequestRequestedApprovers.tsx
View File

@ -158,6 +158,7 @@ export const ChangeRequestAddRequestedApprovers: FC<{
}> = ({ changeRequest, saveClicked, existingReviewers }) => { }> = ({ changeRequest, saveClicked, existingReviewers }) => {
const theme = useTheme(); const theme = useTheme();
const [reviewers, setReviewers] = useState<AvailableReviewerSchema[]>([]); const [reviewers, setReviewers] = useState<AvailableReviewerSchema[]>([]);
const allReviewers = [...existingReviewers, ...reviewers];
const { reviewers: fetchedReviewers, loading: isLoading } = const { reviewers: fetchedReviewers, loading: isLoading } =
useAvailableChangeRequestReviewers( useAvailableChangeRequestReviewers(
changeRequest.project, changeRequest.project,
@ -207,6 +208,13 @@ export const ChangeRequestAddRequestedApprovers: FC<{
options={availableReviewers} options={availableReviewers}
renderOption={renderOption} renderOption={renderOption}
filterOptions={filterOptions} filterOptions={filterOptions}
freeSolo={allReviewers.length >= 10 ? false : undefined}
getOptionDisabled={(options) => {
return (
allReviewers.length >= 10 &&
!reviewers.find((opt) => opt.id === options.id)
);
}}
isOptionEqualToValue={(option, value) => option.id === value.id} isOptionEqualToValue={(option, value) => option.id === value.id}
getOptionLabel={(option: AvailableReviewerSchema) => getOptionLabel={(option: AvailableReviewerSchema) =>
option.email || option.name || option.username || '' option.email || option.name || option.username || ''

7
frontend/src/component/changeRequest/ChangeRequestSidebar/DraftChangeRequestActions/DraftChangeRequestActions.tsx
View File

@ -147,6 +147,13 @@ export const DraftChangeRequestActions: FC<{
options={availableReviewers} options={availableReviewers}
renderOption={renderOption} renderOption={renderOption}
filterOptions={filterOptions} filterOptions={filterOptions}
freeSolo={reviewers.length >= 10 ? false : undefined}
getOptionDisabled={(options) => {
return (
reviewers.length >= 10 &&
!reviewers.find((opt) => opt.id === options.id)
);
}}
isOptionEqualToValue={(option, value) => option.id === value.id} isOptionEqualToValue={(option, value) => option.id === value.id}
getOptionLabel={(option: AvailableReviewerSchema) => getOptionLabel={(option: AvailableReviewerSchema) =>
option.email || option.name || option.username || '' option.email || option.name || option.username || ''