From bf4cbd24b0dcec54afd423a161f3a6cfb82ba080 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nuno=20G=C3=B3is?= Date: Fri, 12 May 2023 09:51:33 +0100 Subject: [PATCH] fix: ensure rel=noreferrer on target=_blank (#3755) https://linear.app/unleash/issue/2-1043/ensure-that-links-with-target=-blank-include-rel=noreferrer-to-prevent Ensures that links with `target="_blank"` include `rel="noreferrer"` to prevent warnings such as: ![image](https://github.com/Unleash/unleash/assets/14320932/9e64df53-b4b9-4346-9394-edb0c2d2d555) https://mathiasbynens.github.io/rel-noopener/#recommendations --- .../apiToken/ConfirmToken/ConfirmToken.tsx | 2 +- .../InstanceStats/InstanceStats.tsx | 1 + .../ServiceAccountModal.tsx | 1 + .../DateSingleValue.test.tsx.snap | 2 +- .../InstanceStatusBar.test.tsx.snap | 2 +- .../common/MessageBanner/MessageBanner.tsx | 2 +- .../common/PremiumFeature/PremiumFeature.tsx | 4 +- .../component/demo/DemoBanner/DemoBanner.tsx | 1 + .../DemoDialogPlans/DemoDialogPlans.tsx | 4 ++ frontend/src/component/demo/demo-topics.tsx | 10 ++++ .../EnvironmentCloneModal.tsx | 1 + .../FeatureStrategySegmentChip.tsx | 6 ++- .../FeedbackCESForm.test.tsx.snap | 2 +- .../__snapshots__/ApiDetails.test.tsx.snap | 2 +- frontend/src/component/menu/Footer/Footer.tsx | 22 +++++++++ .../Footer/__snapshots__/Footer.test.tsx.snap | 46 ++++++++++++++++++- .../__snapshots__/routes.test.tsx.snap | 2 +- .../segments/SegmentProjectAlert.tsx | 7 ++- .../__snapshots__/TagTypeList.test.tsx.snap | 2 +- 19 files changed, 107 insertions(+), 12 deletions(-) diff --git a/frontend/src/component/admin/apiToken/ConfirmToken/ConfirmToken.tsx b/frontend/src/component/admin/apiToken/ConfirmToken/ConfirmToken.tsx index b543876b42..109cd95614 100644 --- a/frontend/src/component/admin/apiToken/ConfirmToken/ConfirmToken.tsx +++ b/frontend/src/component/admin/apiToken/ConfirmToken/ConfirmToken.tsx @@ -36,7 +36,7 @@ export const ConfirmToken = ({ By default, all {TokenType.FRONTEND} tokens may be used from any CORS origin. If you'd like to configure a strict set of origins, please use the{' '} - + CORS origins configuration page . diff --git a/frontend/src/component/admin/instance-admin/InstanceStats/InstanceStats.tsx b/frontend/src/component/admin/instance-admin/InstanceStats/InstanceStats.tsx index 964c6dccb4..fb1dc3f0bd 100644 --- a/frontend/src/component/admin/instance-admin/InstanceStats/InstanceStats.tsx +++ b/frontend/src/component/admin/instance-admin/InstanceStats/InstanceStats.tsx @@ -78,6 +78,7 @@ export const InstanceStats: VFC = () => { color="primary" variant="contained" target="_blank" + rel="noreferrer" href={formatApiPath( '/api/admin/instance-admin/statistics/csv' )} diff --git a/frontend/src/component/admin/serviceAccounts/ServiceAccountsTable/ServiceAccountModal/ServiceAccountModal.tsx b/frontend/src/component/admin/serviceAccounts/ServiceAccountsTable/ServiceAccountModal/ServiceAccountModal.tsx index bc54575903..b76125401d 100644 --- a/frontend/src/component/admin/serviceAccounts/ServiceAccountsTable/ServiceAccountModal/ServiceAccountModal.tsx +++ b/frontend/src/component/admin/serviceAccounts/ServiceAccountsTable/ServiceAccountModal/ServiceAccountModal.tsx @@ -352,6 +352,7 @@ export const ServiceAccountModal = ({ Read more about API tokens diff --git a/frontend/src/component/common/ConstraintAccordion/ConstraintAccordionEdit/ConstraintAccordionEditBody/DateSingleValue/__snapshots__/DateSingleValue.test.tsx.snap b/frontend/src/component/common/ConstraintAccordion/ConstraintAccordionEdit/ConstraintAccordionEditBody/DateSingleValue/__snapshots__/DateSingleValue.test.tsx.snap index b7338e170a..a3e0f94081 100644 --- a/frontend/src/component/common/ConstraintAccordion/ConstraintAccordionEdit/ConstraintAccordionEditBody/DateSingleValue/__snapshots__/DateSingleValue.test.tsx.snap +++ b/frontend/src/component/common/ConstraintAccordion/ConstraintAccordionEdit/ConstraintAccordionEditBody/DateSingleValue/__snapshots__/DateSingleValue.test.tsx.snap @@ -1,4 +1,4 @@ -// Vitest Snapshot v1 +// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html exports[`Date component - snapshot matching 1`] = ` { diff --git a/frontend/src/component/common/InstanceStatus/__snapshots__/InstanceStatusBar.test.tsx.snap b/frontend/src/component/common/InstanceStatus/__snapshots__/InstanceStatusBar.test.tsx.snap index 46c6041bcf..c0d921daa1 100644 --- a/frontend/src/component/common/InstanceStatus/__snapshots__/InstanceStatusBar.test.tsx.snap +++ b/frontend/src/component/common/InstanceStatus/__snapshots__/InstanceStatusBar.test.tsx.snap @@ -1,4 +1,4 @@ -// Vitest Snapshot v1 +// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html exports[`InstanceStatusBar should warn when the trial has churned 1`] = `