Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-08-04 13:48:56 +02:00
Code Issues Projects Releases Wiki Activity

Fix each child in a list should have a key error. (#10393)

Browse Source 
The console was complaining. I suspect it was because of the wrapping
fragment. So instead of doing everything within react, I switched to
using a standard case statement.

Also: because name is optional and not guaranteed to be unique, let's
use id for the key instead.
This commit is contained in:
Thomas Heartman 2025-07-22 15:03:33 +02:00 committed by GitHub
parent d7f98945a3
commit bfd82015d1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 15 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
frontend/src/component/changeRequest/ChangeRequestOverview/ChangeRequestRequestedApprovers/ChangeRequestRequestedApprovers.tsx
View File

@ -350,31 +350,21 @@ export const ChangeRequestRequestedApprovers: FC<{
saveClicked={saveClicked} saveClicked={saveClicked}
/> />
)} )}
{reviewers.map((reviewer) => ( {reviewers.map((reviewer) => {
<> const key = reviewer.id;
{reviewer.status === 'approved' && ( const props = {
<ChangeRequestApprover name: reviewer.name || 'Unknown user',
key={reviewer.name} imageUrl: reviewer.imageUrl,
name={reviewer.name || 'Unknown user'} };
imageUrl={reviewer.imageUrl} switch (reviewer.status) {
/> case 'approved':
)} return <ChangeRequestApprover key={key} {...props} />;
{reviewer.status === 'rejected' && ( case 'rejected':
<ChangeRequestRejector return <ChangeRequestRejector key={key} {...props} />;
key={reviewer.name} case 'pending':
name={reviewer.name || 'Unknown user'} return <ChangeRequestPending key={key} {...props} />;
imageUrl={reviewer.imageUrl} }
/> })}
)}
{reviewer.status === 'pending' && (
<ChangeRequestPending
key={reviewer.name}
name={reviewer.name || 'Unknown user'}
imageUrl={reviewer.imageUrl}
/>
)}
</>
))}
</Paper> </Paper>
); );
}; };