mirror of
https://github.com/Unleash/unleash.git
synced 2025-02-23 00:22:19 +01:00
fix: disable SCIM for OIDC, nothing to test it on (#6937)
disable SCIM for OIDC, nothing to test it on Also checks scim enabled before saving
This commit is contained in:
parent
b6865a5a9d
commit
c048156e19
@ -21,10 +21,6 @@ import { formatUnknownError } from 'utils/formatUnknownError';
|
|||||||
import { removeEmptyStringFields } from 'utils/removeEmptyStringFields';
|
import { removeEmptyStringFields } from 'utils/removeEmptyStringFields';
|
||||||
import { SsoGroupSettings } from '../SsoGroupSettings';
|
import { SsoGroupSettings } from '../SsoGroupSettings';
|
||||||
import type { IRole } from 'interfaces/role';
|
import type { IRole } from 'interfaces/role';
|
||||||
import { useUiFlag } from 'hooks/useUiFlag';
|
|
||||||
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
|
|
||||||
import { useScim } from 'hooks/useScim';
|
|
||||||
import { ScimConfigSettings } from '../ScimSettings/ScimSettings';
|
|
||||||
|
|
||||||
const initialState = {
|
const initialState = {
|
||||||
enabled: false,
|
enabled: false,
|
||||||
@ -89,22 +85,6 @@ export const OidcAuth = () => {
|
|||||||
});
|
});
|
||||||
};
|
};
|
||||||
|
|
||||||
const {
|
|
||||||
settings,
|
|
||||||
enabled,
|
|
||||||
setEnabled,
|
|
||||||
assumeControlOfExisting,
|
|
||||||
setAssumeControlOfExisting,
|
|
||||||
newToken,
|
|
||||||
tokenGenerationDialog,
|
|
||||||
setTokenGenerationDialog,
|
|
||||||
tokenDialog,
|
|
||||||
setTokenDialog,
|
|
||||||
loading: scimLoading,
|
|
||||||
saveScimSettings,
|
|
||||||
onGenerateNewTokenConfirm,
|
|
||||||
} = useScim();
|
|
||||||
|
|
||||||
const onSubmit = async (event: React.SyntheticEvent) => {
|
const onSubmit = async (event: React.SyntheticEvent) => {
|
||||||
event.preventDefault();
|
event.preventDefault();
|
||||||
|
|
||||||
@ -114,14 +94,11 @@ export const OidcAuth = () => {
|
|||||||
title: 'Settings stored',
|
title: 'Settings stored',
|
||||||
type: 'success',
|
type: 'success',
|
||||||
});
|
});
|
||||||
saveScimSettings();
|
|
||||||
} catch (error: unknown) {
|
} catch (error: unknown) {
|
||||||
setToastApiError(formatUnknownError(error));
|
setToastApiError(formatUnknownError(error));
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
const scimEnabled = useUiFlag('scimApi');
|
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<>
|
<>
|
||||||
<Grid container sx={{ mb: 3 }}>
|
<Grid container sx={{ mb: 3 }}>
|
||||||
@ -279,31 +256,6 @@ export const OidcAuth = () => {
|
|||||||
setValue={setValue}
|
setValue={setValue}
|
||||||
/>
|
/>
|
||||||
|
|
||||||
<ConditionallyRender
|
|
||||||
condition={scimEnabled}
|
|
||||||
show={
|
|
||||||
<ScimConfigSettings
|
|
||||||
disabled={!data.enabled}
|
|
||||||
settings={settings}
|
|
||||||
enabled={enabled}
|
|
||||||
setEnabled={setEnabled}
|
|
||||||
assumeControlOfExisting={assumeControlOfExisting}
|
|
||||||
setAssumeControlOfExisting={
|
|
||||||
setAssumeControlOfExisting
|
|
||||||
}
|
|
||||||
newToken={newToken}
|
|
||||||
tokenGenerationDialog={tokenGenerationDialog}
|
|
||||||
setTokenGenerationDialog={setTokenGenerationDialog}
|
|
||||||
tokenDialog={tokenDialog}
|
|
||||||
setTokenDialog={setTokenDialog}
|
|
||||||
loading={scimLoading}
|
|
||||||
onGenerateNewTokenConfirm={
|
|
||||||
onGenerateNewTokenConfirm
|
|
||||||
}
|
|
||||||
/>
|
|
||||||
}
|
|
||||||
/>
|
|
||||||
|
|
||||||
<AutoCreateForm
|
<AutoCreateForm
|
||||||
data={data}
|
data={data}
|
||||||
setValue={setValue}
|
setValue={setValue}
|
||||||
|
@ -80,6 +80,8 @@ export const SamlAuth = () => {
|
|||||||
});
|
});
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const scimEnabled = useUiFlag('scimApi');
|
||||||
|
|
||||||
const {
|
const {
|
||||||
settings,
|
settings,
|
||||||
enabled,
|
enabled,
|
||||||
@ -105,14 +107,14 @@ export const SamlAuth = () => {
|
|||||||
title: 'Settings stored',
|
title: 'Settings stored',
|
||||||
type: 'success',
|
type: 'success',
|
||||||
});
|
});
|
||||||
|
if (scimEnabled) {
|
||||||
saveScimSettings();
|
saveScimSettings();
|
||||||
|
}
|
||||||
} catch (error: unknown) {
|
} catch (error: unknown) {
|
||||||
setToastApiError(formatUnknownError(error));
|
setToastApiError(formatUnknownError(error));
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
const scimEnabled = useUiFlag('scimApi');
|
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<>
|
<>
|
||||||
<Grid container sx={{ mb: 3 }}>
|
<Grid container sx={{ mb: 3 }}>
|
||||||
|
Loading…
Reference in New Issue
Block a user