From c0a8c6f9f1ceeadc73d94742c778ce89a0935e1f Mon Sep 17 00:00:00 2001
From: sjaanus <sellinjaanus@gmail.com>
Date: Fri, 22 Jul 2022 19:33:58 +0000
Subject: [PATCH] Fix user/group role primary keys

---
 src/lib/db/access-store.ts                    |  4 +--
 ...0220722221524-update-access-constraints.js | 25 +++++++++++++++++++
 2 files changed, 27 insertions(+), 2 deletions(-)
 create mode 100644 src/migrations/20220722221524-update-access-constraints.js

diff --git a/src/lib/db/access-store.ts b/src/lib/db/access-store.ts
index b1eb409ed3..1a68b17a90 100644
--- a/src/lib/db/access-store.ts
+++ b/src/lib/db/access-store.ts
@@ -375,13 +375,13 @@ export class AccessStore implements IAccessStore {
             if (userRows.length > 0) {
                 await tx(T.ROLE_USER)
                     .insert(userRows)
-                    .onConflict(['project', 'role_id', 'user_id'])
+                    .onConflict(['project', 'user_id'])
                     .merge();
             }
             if (groupRows.length > 0) {
                 await tx(T.GROUP_ROLE)
                     .insert(groupRows)
-                    .onConflict(['project', 'role_id', 'group_id'])
+                    .onConflict(['project', 'group_id'])
                     .merge();
             }
         });
diff --git a/src/migrations/20220722221524-update-access-constraints.js b/src/migrations/20220722221524-update-access-constraints.js
new file mode 100644
index 0000000000..b2bf5cd0fb
--- /dev/null
+++ b/src/migrations/20220722221524-update-access-constraints.js
@@ -0,0 +1,25 @@
+'use strict';
+
+exports.up = function (db, callback) {
+    db.runSql(
+        `
+            ALTER TABLE role_user DROP CONSTRAINT role_user_pkey;
+            ALTER TABLE role_user ADD PRIMARY KEY (user_id, project);
+            ALTER TABLE group_role DROP CONSTRAINT group_role_pkey;
+            ALTER TABLE group_role ADD PRIMARY KEY (group_id, project);
+        `,
+        callback,
+    );
+};
+
+exports.down = function (db, callback) {
+    db.runSql(
+        `
+            ALTER TABLE role_user DROP CONSTRAINT role_user_pkey;
+            ALTER TABLE role_user ADD PRIMARY KEY (user_id, role_id, project);
+            ALTER TABLE group_role DROP CONSTRAINT group_role_pkey;
+            ALTER TABLE group_role ADD PRIMARY KEY (group_id, role_id, project);
+        `,
+        callback,
+    );
+};