Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

refactor: centralize number formatting (#10716)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2025-10-02 09:36:27 +02:00 committed by GitHub
parent 921130a9c0
commit c2b598d8d9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
frontend/src/component/impact-metrics/metricsFormatters.test.ts
View File

@ -7,14 +7,14 @@ describe('formatLargeNumbers', () => {
});
it('formats thousands correctly', () => {
expect(formatLargeNumbers(1000)).toBe('1k');
expect(formatLargeNumbers(1200)).toBe('1.2k');
expect(formatLargeNumbers(1400)).toBe('1.4k');
expect(formatLargeNumbers(1600)).toBe('1.6k');
expect(formatLargeNumbers(5000)).toBe('5k');
expect(formatLargeNumbers(9500)).toBe('9.5k');
expect(formatLargeNumbers(10000)).toBe('10k');
expect(formatLargeNumbers(999000)).toBe('999k');
expect(formatLargeNumbers(1000)).toBe('1K');
expect(formatLargeNumbers(1200)).toBe('1.2K');
expect(formatLargeNumbers(1400)).toBe('1.4K');
expect(formatLargeNumbers(1600)).toBe('1.6K');
expect(formatLargeNumbers(5000)).toBe('5K');
expect(formatLargeNumbers(9500)).toBe('9.5K');
expect(formatLargeNumbers(10000)).toBe('10K');
expect(formatLargeNumbers(999000)).toBe('999K');
});
it('formats millions correctly', () => {

6
frontend/src/component/impact-metrics/metricsFormatters.ts
View File

@ -53,11 +53,7 @@ export const getSeriesLabel = (metric: Record<string, string>): string => {
return `${__name__} (${labelParts})`;
};
export const formatLargeNumbers = (value: number): string => {
const formatter = prettifyLargeNumber(1000, 1);
const result = formatter(value);
return result.replace(/K/g, 'k');
};
export const formatLargeNumbers = prettifyLargeNumber(1000, 1);
export const getMetricType = (seriesName: string) => {
if (seriesName.startsWith('unleash_counter_')) return 'counter';