From c3e8d743bc33738761e8f591bdfb29dbe95ebfa2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gast=C3=B3n=20Fournier?= Date: Fri, 6 Oct 2023 16:31:39 +0200 Subject: [PATCH] chore: Improve UI Config type (#4959) Fix link types --- src/lib/db/transaction.ts | 2 +- src/lib/types/option.ts | 14 ++++++-------- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/src/lib/db/transaction.ts b/src/lib/db/transaction.ts index e26a435de8..57c6905aa1 100644 --- a/src/lib/db/transaction.ts +++ b/src/lib/db/transaction.ts @@ -27,7 +27,7 @@ export type WithTransactional = S & { }; /** - * @deprecated this is a temporal solution to deal with transactions at the store level. + * @deprecated this is a temporary solution to deal with transactions at the store level. * Ideally, we should handle transactions at the service level (each service method should be transactional). * The controller should define the transactional scope as follows: * https://github.com/Unleash/unleash/blob/cb034976b93abc799df774858d716a49f645d669/src/lib/features/export-import-toggles/export-import-controller.ts#L206-L208 diff --git a/src/lib/types/option.ts b/src/lib/types/option.ts index 11d166a3f3..48c2f2b014 100644 --- a/src/lib/types/option.ts +++ b/src/lib/types/option.ts @@ -148,14 +148,12 @@ export interface IUIConfig { environment?: string; slogan?: string; name?: string; - links?: [ - { - value: string; - icon?: string; - href: string; - title: string; - }, - ]; + links?: { + value: string; + icon?: string; + href: string; + title: string; + }[]; flags?: IFlags; }