Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-05-22 01:16:07 +02:00
Code Issues Projects Releases Wiki Activity

fix: Strategy schema should allow deprecated field (#700)

Browse Source 
fixes: #698
This commit is contained in:
Ivar Conradi Østhus 2021-02-01 09:41:50 +01:00 committed by GitHub
parent 187798262e
commit c500128f07
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 55 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
lib/services/strategy-schema.js
View File

@ -3,29 +3,33 @@
const joi = require('joi'); const joi = require('joi');
const { nameType } = require('../routes/admin-api/util'); const { nameType } = require('../routes/admin-api/util');
const strategySchema = joi.object().keys({ const strategySchema = joi
name: nameType, .object()
editable: joi.boolean().default(true), .keys({
description: joi name: nameType,
.string() editable: joi.boolean().default(true),
.allow(null) deprecated: joi.boolean().default(false),
.allow('') description: joi
.optional(), .string()
parameters: joi .allow(null)
.array() .allow('')
.required() .optional(),
.items( parameters: joi
joi.object().keys({ .array()
name: joi.string().required(), .required()
type: joi.string().required(), .items(
description: joi joi.object().keys({
.string() name: joi.string().required(),
.allow(null) type: joi.string().required(),
.allow('') description: joi
.optional(), .string()
required: joi.boolean(), .allow(null)
}), .allow('')
), .optional(),
}); required: joi.boolean(),
}),
),
})
.options({ allowUnknown: false, stripUnknown: true, abortEarly: false });
module.exports = strategySchema; module.exports = strategySchema;

27
test/e2e/api/admin/strategy.e2e.test.js
View File

@ -172,3 +172,30 @@ test.serial('cannot deprecate default strategy', async t => {
const request = await setupApp(stores); const request = await setupApp(stores);
await request.post('/api/admin/strategies/default/deprecate').expect(403); await request.post('/api/admin/strategies/default/deprecate').expect(403);
}); });
test.serial('can update a exiting strategy with deprecated', async t => {
t.plan(0);
const request = await setupApp(stores);
await request
.post('/api/admin/strategies')
.send({
name: 'myCustomStrategyDepreacted',
description: 'Best strategy ever.',
parameters: [],
deprecated: true,
})
.set('Content-Type', 'application/json');
const { body: strategy } = await request.get(
'/api/admin/strategies/myCustomStrategyDepreacted',
);
strategy.description = 'A new desc';
return request
.put('/api/admin/strategies/default')
.send(strategy)
.set('Content-Type', 'application/json')
.expect(200);
});