Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-09 00:18:00 +01:00
Code Issues Projects Releases Wiki Activity

fix: update testIds in the feature form

Browse Source
This commit is contained in:
Youssef 2022-01-24 23:05:11 +01:00
parent e0f8611c7c
commit c6d5f4b278
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/component/feature/CreateFeature/CreateFeature/CreateFeature.tsx
View File

@ -7,6 +7,7 @@ import useToast from '../../../../hooks/useToast';
import useFeatureApi from '../../../../hooks/api/actions/useFeatureApi/useFeatureApi'; import useFeatureApi from '../../../../hooks/api/actions/useFeatureApi/useFeatureApi';
import { CREATE_FEATURE } from '../../../providers/AccessProvider/permissions'; import { CREATE_FEATURE } from '../../../providers/AccessProvider/permissions';
import PermissionButton from '../../../common/PermissionButton/PermissionButton'; import PermissionButton from '../../../common/PermissionButton/PermissionButton';
import { CF_CREATE_BTN_ID } from '../../../../testIds';
const CreateFeature = () => { const CreateFeature = () => {
/* @ts-ignore */ /* @ts-ignore */
@ -92,6 +93,7 @@ const CreateFeature = () => {
permission={CREATE_FEATURE} permission={CREATE_FEATURE}
projectId={project} projectId={project}
type="submit" type="submit"
data-test={CF_CREATE_BTN_ID}
> >
Create toggle Create toggle
</PermissionButton> </PermissionButton>

9
frontend/src/component/feature/CreateFeature/FeatureForm/FeatureForm.tsx
View File

@ -3,7 +3,11 @@ import Input from '../../../common/Input/Input';
import { Button } from '@material-ui/core'; import { Button } from '@material-ui/core';
import { useStyles } from './FeatureForm.styles'; import { useStyles } from './FeatureForm.styles';
import FeatureTypeSelect from '../../FeatureView2/FeatureSettings/FeatureSettingsMetadata/FeatureTypeSelect/FeatureTypeSelect'; import FeatureTypeSelect from '../../FeatureView2/FeatureSettings/FeatureSettingsMetadata/FeatureTypeSelect/FeatureTypeSelect';
import { CF_DESC_ID, CF_TYPE_ID } from '../../../../testIds'; import {
CF_DESC_ID,
CF_NAME_ID,
CF_TYPE_ID,
} from '../../../../testIds';
import useFeatureTypes from '../../../../hooks/api/getters/useFeatureTypes/useFeatureTypes'; import useFeatureTypes from '../../../../hooks/api/getters/useFeatureTypes/useFeatureTypes';
import { KeyboardArrowDownOutlined } from '@material-ui/icons'; import { KeyboardArrowDownOutlined } from '@material-ui/icons';
import useUser from '../../../../hooks/api/getters/useUser/useUser'; import useUser from '../../../../hooks/api/getters/useUser/useUser';
@ -89,6 +93,9 @@ const FeatureForm: React.FC<IFeatureToggleForm> = ({
onFocus={() => clearErrors()} onFocus={() => clearErrors()}
value={name} value={name}
onChange={e => setName(trim(e.target.value))} onChange={e => setName(trim(e.target.value))}
inputProps={{
'data-test': CF_NAME_ID,
}}
/> />
<ConditionallyRender <ConditionallyRender
condition={editable} condition={editable}