Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-09 00:18:00 +01:00
Code Issues Projects Releases Wiki Activity

fix: add properties to legacy endpoints (#919)

Browse Source 
Co-authored-by: Ivar Conradi Østhus <ivarconr@gmail.com>
This commit is contained in:
Fredrik Strand Oseberg 2021-08-19 13:34:24 +02:00 committed by GitHub
parent f2eb3c101f
commit cdc2e7daee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/lib/db/feature-strategy-store.ts
View File

@ -272,6 +272,7 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
acc.description = r.description;
acc.stale = r.stale;
acc.variants = r.variants;
acc.createdAt = r.created_at;
acc.lastSeenAt = r.last_seen_at;
acc.type = r.type;
if (!acc.environments[r.environment]) {

34
src/lib/routes/admin-api/feature.ts
View File

@ -103,14 +103,20 @@ class FeatureController extends Controller {
res: Response,
): Promise<void> {
const name = req.params.featureName;
const feature = await this.getLegacyFeatureToggle(name);
res.json(feature).end();
}
private async getLegacyFeatureToggle(name: string): Promise<any> {
const feature = await this.featureService2.getFeatureToggle(name);
const strategies =
feature.environments.find((e) => e.name === GLOBAL_ENV)
?.strategies || [];
res.json({
...feature,
strategies,
}).end();
const globalEnv = feature.environments.find(
(e) => e.name === GLOBAL_ENV,
);
const strategies = globalEnv?.strategies || [];
const enabled = globalEnv?.enabled || false;
delete feature.environments;
return { ...feature, enabled, strategies };
}
async listTags(req: Request, res: Response): Promise<void> {
@ -280,22 +286,16 @@ class FeatureController extends Controller {
async staleOn(req: Request, res: Response): Promise<void> {
const { featureName } = req.params;
const userName = extractUser(req);
const feature = await this.featureService2.updateStale(
featureName,
true,
userName,
);
await this.featureService2.updateStale(featureName, true, userName);
const feature = await this.getLegacyFeatureToggle(featureName);
res.json(feature).end();
}
async staleOff(req: Request, res: Response): Promise<void> {
const { featureName } = req.params;
const userName = extractUser(req);
const feature = await this.featureService2.updateStale(
featureName,
false,
userName,
);
await this.featureService2.updateStale(featureName, false, userName);
const feature = await this.getLegacyFeatureToggle(featureName);
res.json(feature).end();
}