From cf87f8cfe1a03ac28a26e5d8a48bbbb3f5e185a4 Mon Sep 17 00:00:00 2001
From: Jaanus Sellin <sellinjaanus@gmail.com>
Date: Wed, 4 Jun 2025 10:32:32 +0300
Subject: [PATCH] feat: make lifecycle trends more detailed (#10079)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

## ✨ PR Summary: Update `lifecycle_trends` Table Schema

### ✅ What Changed

- **Updated `stage` column constraint**
- **Old values:** `'initial', 'develop', 'production', 'cleanup',
'archived'`
- **New values:** `'initial', 'pre-live', 'live', 'completed',
'archived'`

- **Replaced `flag_type` CHECK constraint with a foreign key**
  - Removed hardcoded values: `'experimental', 'release', 'permanent'`
  - Added foreign key:
    ```sql
FOREIGN KEY (flag_type) REFERENCES feature_types(id) ON DELETE CASCADE
    ```

- **Added down migration** to:
  - Restore original `stage` constraint
- Drop the foreign key on `flag_type` and re-add the original CHECK
constraint

### 💡 Why

- Align `stage` values with lifecycle model
- Use the `feature_types` table to ensure referential integrity
---
 ...20250604100546-lifecycle-trends-general.js | 44 +++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 src/migrations/20250604100546-lifecycle-trends-general.js

diff --git a/src/migrations/20250604100546-lifecycle-trends-general.js b/src/migrations/20250604100546-lifecycle-trends-general.js
new file mode 100644
index 0000000000..d19645babd
--- /dev/null
+++ b/src/migrations/20250604100546-lifecycle-trends-general.js
@@ -0,0 +1,44 @@
+'use strict';
+
+exports.up = function(db, cb) {
+    db.runSql(
+        `
+            -- 1. Drop old CHECK constraint on 'stage' and add new one
+            ALTER TABLE lifecycle_trends
+                DROP CONSTRAINT IF EXISTS lifecycle_trends_stage_check,
+                ADD CONSTRAINT lifecycle_trends_stage_check
+                    CHECK (stage IN ('initial', 'pre-live', 'live', 'completed', 'archived'));
+
+            -- 2. Drop old CHECK constraint on 'flag_type'
+            ALTER TABLE lifecycle_trends
+                DROP CONSTRAINT IF EXISTS lifecycle_trends_flag_type_check;
+
+            -- 3. Add foreign key to 'flag_type' referencing 'feature_types(id)'
+            ALTER TABLE lifecycle_trends
+                ADD CONSTRAINT lifecycle_trends_flag_type_fkey
+                    FOREIGN KEY (flag_type)
+                    REFERENCES feature_types(id)
+                    ON DELETE CASCADE;
+        `,
+        cb,
+    );
+};
+
+exports.down = function(db, cb) {
+    db.runSql(`
+            -- 1. Drop foreign key constraint on 'flag_type'
+            ALTER TABLE lifecycle_trends
+                DROP CONSTRAINT IF EXISTS lifecycle_trends_flag_type_fkey;
+
+            -- 2. Restore original CHECK constraint on 'flag_type'
+            ALTER TABLE lifecycle_trends
+                ADD CONSTRAINT lifecycle_trends_flag_type_check
+                    CHECK (flag_type IN ('experimental', 'release', 'permanent'));
+
+            -- 3. Restore original CHECK constraint on 'stage'
+            ALTER TABLE lifecycle_trends
+                DROP CONSTRAINT IF EXISTS lifecycle_trends_stage_check,
+                ADD CONSTRAINT lifecycle_trends_stage_check
+                    CHECK (stage IN ('initial','develop', 'production', 'cleanup', 'archived'));
+    `, cb);
+};