Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-08-18 13:48:58 +02:00
Code Issues Projects Releases Wiki Activity

fix: ReportTable not updating status dynamically (#4923)

Browse Source 
Fixes a bug with the UI where featureType comparison was using name
instead of id

---------

Signed-off-by: andreas-unleash <andreas@getunleash.ai>
This commit is contained in:
andreas-unleash 2023-10-04 15:11:07 +03:00 committed by GitHub
parent d5b4933df1
commit d13aec75f1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/component/project/Project/ProjectHealth/ReportTable/ReportExpiredCell/formatExpiredAt.ts
View File

@ -11,7 +11,7 @@ export const formatExpiredAt = (
const { type, createdAt } = feature; const { type, createdAt } = feature;
const featureType = featureTypes.find( const featureType = featureTypes.find(
featureType => featureType.name === type featureType => featureType.id === type
); );
if ( if (

3
frontend/src/component/project/Project/ProjectHealth/ReportTable/ReportStatusCell/formatStatus.ts
View File

@ -13,12 +13,11 @@ export const formatStatus = (
const { type, createdAt } = feature; const { type, createdAt } = feature;
const featureType = featureTypes.find( const featureType = featureTypes.find(
featureType => featureType.name === type featureType => featureType.id === type
); );
const date = parseISO(createdAt); const date = parseISO(createdAt);
const now = new Date(); const now = new Date();
const diff = getDiffInDays(date, now); const diff = getDiffInDays(date, now);
if ( if (
featureType && featureType &&
expired(diff, featureType) && expired(diff, featureType) &&

10
frontend/src/component/project/Project/ProjectHealth/ReportTable/ReportTable.tsx
View File

@ -59,9 +59,8 @@ export const ReportTable = ({ projectId, features }: IReportTableProps) => {
); );
const { featureTypes } = useFeatureTypes(); const { featureTypes } = useFeatureTypes();
const data: IReportTableRow[] = useMemo<IReportTableRow[]>( const data: IReportTableRow[] = useMemo<IReportTableRow[]>(() => {
() => return features.map(report => ({
features.map(report => ({
project: projectId, project: projectId,
name: report.name, name: report.name,
type: report.type, type: report.type,
@ -71,9 +70,8 @@ export const ReportTable = ({ projectId, features }: IReportTableProps) => {
lastSeenAt: report.lastSeenAt, lastSeenAt: report.lastSeenAt,
createdAt: report.createdAt, createdAt: report.createdAt,
expiredAt: formatExpiredAt(report, featureTypes), expiredAt: formatExpiredAt(report, featureTypes),
})), }));
[projectId, features] }, [projectId, features, featureTypes]);
);
const initialState = useMemo( const initialState = useMemo(
() => ({ () => ({