From d1c3be3b9ef2496b809b6a1b47ca20fd5745e65d Mon Sep 17 00:00:00 2001
From: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
Date: Fri, 19 May 2023 12:47:55 +0200
Subject: [PATCH] Tracking for default strategy (#3800)

---
 .../EditDefaultStrategy.tsx                   | 47 +++----------------
 frontend/src/hooks/usePlausibleTracker.ts     |  3 +-
 2 files changed, 8 insertions(+), 42 deletions(-)

diff --git a/frontend/src/component/project/Project/ProjectSettings/ProjectDefaultStrategySettings/ProjectEnvironment/ProjectEnvironmentDefaultStrategy/EditDefaultStrategy.tsx b/frontend/src/component/project/Project/ProjectSettings/ProjectDefaultStrategySettings/ProjectEnvironment/ProjectEnvironmentDefaultStrategy/EditDefaultStrategy.tsx
index 247a01c6fc..7945fd5842 100644
--- a/frontend/src/component/project/Project/ProjectSettings/ProjectDefaultStrategySettings/ProjectEnvironment/ProjectEnvironmentDefaultStrategy/EditDefaultStrategy.tsx
+++ b/frontend/src/component/project/Project/ProjectSettings/ProjectDefaultStrategySettings/ProjectEnvironment/ProjectEnvironmentDefaultStrategy/EditDefaultStrategy.tsx
@@ -42,45 +42,8 @@ const EditDefaultStrategy = ({ strategy }: EditDefaultStrategyProps) => {
     const { unleashUrl } = uiConfig;
     const navigate = useNavigate();
 
-    const [previousTitle] = useState<string>('');
     const { trackEvent } = usePlausibleTracker();
 
-    const trackTitle = (title: string = '') => {
-        // don't expose the title, just if it was added, removed, or edited
-        if (title === previousTitle) {
-            trackEvent('strategyTitle', {
-                props: {
-                    action: 'none',
-                    on: 'edit',
-                },
-            });
-        }
-        if (previousTitle === '' && title !== '') {
-            trackEvent('strategyTitle', {
-                props: {
-                    action: 'added',
-                    on: 'edit',
-                },
-            });
-        }
-        if (previousTitle !== '' && title === '') {
-            trackEvent('strategyTitle', {
-                props: {
-                    action: 'removed',
-                    on: 'edit',
-                },
-            });
-        }
-        if (previousTitle !== '' && title !== '' && title !== previousTitle) {
-            trackEvent('strategyTitle', {
-                props: {
-                    action: 'edited',
-                    on: 'edit',
-                },
-            });
-        }
-    };
-
     const {
         segments: allSegments,
         refetchSegments: refetchSavedStrategySegments,
@@ -110,10 +73,12 @@ const EditDefaultStrategy = ({ strategy }: EditDefaultStrategyProps) => {
     ) => {
         await updateDefaultStrategy(projectId, environmentId, payload);
 
-        if (uiConfig?.flags?.strategyImprovements && strategy.title) {
-            // NOTE: remove tracking when feature flag is removed
-            trackTitle(strategy.title);
-        }
+        trackEvent('default_strategy', {
+            props: {
+                action: 'edit',
+                hasTitle: Boolean(payload.title),
+            },
+        });
 
         await refetchSavedStrategySegments();
         setToastData({
diff --git a/frontend/src/hooks/usePlausibleTracker.ts b/frontend/src/hooks/usePlausibleTracker.ts
index b66edb6c19..ae01099b39 100644
--- a/frontend/src/hooks/usePlausibleTracker.ts
+++ b/frontend/src/hooks/usePlausibleTracker.ts
@@ -25,7 +25,8 @@ export type CustomEvents =
     | 'notifications'
     | 'batch_operations'
     | 'strategyTitle'
-    | 'demo';
+    | 'demo'
+    | 'default_strategy';
 
 export const usePlausibleTracker = () => {
     const plausible = useContext(PlausibleContext);