Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-25 00:07:47 +01:00
Code Issues Projects Releases Wiki Activity

fix: Cannot remove all variants in Admin UI

Browse Source 
see https://github.com/Unleash/unleash/issues/544
This commit is contained in:
Ivar Conradi Østhus 2020-01-06 20:12:36 +01:00
parent e837aebb66
commit d297186acb
2 changed files with 91 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

74
frontend/src/component/feature/variant/__tests__/__snapshots__/update-variant-component-test.jsx.snap
View File

@ -205,6 +205,59 @@ exports[`renders correctly with without variants 1`] = `
Add variant
</a>
</p>
<form>
<table
className="mdl-data-table mdl-shadow--2dp variantTable"
>
<thead>
<tr>
<th>
Name
</th>
<th>
Weight
</th>
<th
className="actions"
/>
</tr>
</thead>
<tbody />
</table>
<br />
<div>
<react-mdl-Button
icon="add"
primary={true}
raised={true}
ripple={true}
type="submit"
>
<react-mdl-Icon
name="add"
/>
   
Save
</react-mdl-Button>
 
<react-mdl-Button
onClick={[MockFunction]}
raised={true}
ripple={true}
style={
Object {
"float": "right",
}
}
type="cancel"
>
<react-mdl-Icon
name="cancel"
/>
    Cancel
</react-mdl-Button>
</div>
</form>
</section>
`;
@ -240,5 +293,26 @@ exports[`renders correctly with without variants and no permissions 1`] = `
>
The sum of variants weights needs to be a constant number to guarantee consistent hashing in the client implementations, this is why we will sometime allocate a few more percentages to the first variant if the sum is not exactly 100. In a final version of this feature it should be possible to the user to manually set the percentages for each variant.
</p>
<form>
<table
className="mdl-data-table mdl-shadow--2dp variantTable"
>
<thead>
<tr>
<th>
Name
</th>
<th>
Weight
</th>
<th
className="actions"
/>
</tr>
</thead>
<tbody />
</table>
<br />
</form>
</section>
`;

35
frontend/src/component/feature/variant/update-variant-component.jsx
View File

@ -122,26 +122,25 @@ class UpdateVariantComponent extends Component {
Add variant
</a>
</p>
) : null}
{variants.length > 0 ? (
<form onSubmit={onSubmit(input, features)}>
<table className={['mdl-data-table mdl-shadow--2dp', styles.variantTable].join(' ')}>
<thead>
<tr>
<th>Name</th>
<th>Weight</th>
<th className={styles.actions} />
</tr>
</thead>
<tbody>{variants.map(this.renderVariant)}</tbody>
</table>
<br />
{this.props.hasPermission(UPDATE_FEATURE) ? (
<FormButtons submitText={'Save'} onCancel={onCancel} />
) : null}
</form>
) : null}
<form onSubmit={onSubmit(input, features)}>
<table className={['mdl-data-table mdl-shadow--2dp', styles.variantTable].join(' ')}>
<thead>
<tr>
<th>Name</th>
<th>Weight</th>
<th className={styles.actions} />
</tr>
</thead>
<tbody>{variants.map(this.renderVariant)}</tbody>
</table>
<br />
{this.props.hasPermission(UPDATE_FEATURE) ? (
<FormButtons submitText={'Save'} onCancel={onCancel} />
) : null}
</form>
</section>
);
}