Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-01 13:47:27 +02:00
Code Issues Projects Releases Wiki Activity

5.6.5 (#5307)

Browse Source
This commit is contained in:
Jaanus Sellin 2023-11-09 13:41:39 +02:00 committed by GitHub
parent 76d6ce45a9
commit d44e00f0e4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 50 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/lib/features/feature-search/feature.search.e2e.test.ts
View File

@ -106,6 +106,26 @@ test('should search matching features by tag', async () => {
});
});
test('should return all feature tags', async () => {
await app.createFeature('my_feature_a');
await app.addTag('my_feature_a', { type: 'simple', value: 'my_tag' });
await app.addTag('my_feature_a', { type: 'simple', value: 'second_tag' });
const { body } = await searchFeatures({});
expect(body).toMatchObject({
features: [
{
name: 'my_feature_a',
tags: [
{ type: 'simple', value: 'my_tag' },
{ type: 'simple', value: 'second_tag' },
],
},
],
});
});
test('should return empty features', async () => {
const { body } = await searchFeatures({ query: '' });
expect(body).toMatchObject({ features: [] });

46
src/lib/features/feature-toggle/feature-toggle-strategies-store.ts
View File

@ -105,18 +105,6 @@ function mapInput(input: IFeatureStrategy): IFeatureStrategiesTable {
};
}
const getUniqueRows = (rows: any[]) => {
const seen = {};
return rows.filter((row) => {
const key = `${row.environment}-${row.feature_name}`;
if (seen[key]) {
return false;
}
seen[key] = true;
return true;
});
};
const sortEnvironments = (overview: IFeatureOverview) => {
return Object.values(overview).map((data: IFeatureOverview) => ({
...data,
@ -252,7 +240,10 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
environment: string,
): Promise<void> {
await this.db('feature_strategies')
.where({ feature_name: featureName, environment })
.where({
feature_name: featureName,
environment,
})
.del();
}
@ -295,8 +286,14 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
environment,
})
.orderBy([
{ column: 'sort_order', order: 'asc' },
{ column: 'created_at', order: 'asc' },
{
column: 'sort_order',
order: 'asc',
},
{
column: 'created_at',
order: 'asc',
},
]);
stopTimer();
return rows.map(mapRow);
@ -637,7 +634,7 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
query = query.select(selectColumns);
const rows = await query;
if (rows.length > 0) {
const overview = this.getFeatureOverviewData(getUniqueRows(rows));
const overview = this.getFeatureOverviewData(rows);
return sortEnvironments(overview);
}
return [];
@ -752,7 +749,7 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
query = query.select(selectColumns);
const rows = await query;
if (rows.length > 0) {
const overview = this.getFeatureOverviewData(getUniqueRows(rows));
const overview = this.getFeatureOverviewData(rows);
return sortEnvironments(overview);
}
return [];
@ -761,9 +758,18 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
getFeatureOverviewData(rows): IFeatureOverview {
return rows.reduce((acc, row) => {
if (acc[row.feature_name] !== undefined) {
const environmentExists = acc[
row.feature_name
].environments.some(
(existingEnvironment) =>
existingEnvironment.name === row.environment,
);
if (!environmentExists) {
acc[row.feature_name].environments.push(
FeatureStrategiesStore.getEnvironment(row),
);
}
if (this.isNewTag(acc[row.feature_name], row)) {
this.addTag(acc[row.feature_name], row);
}
@ -779,6 +785,7 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
impressionData: row.impression_data,
environments: [FeatureStrategiesStore.getEnvironment(row)],
};
if (this.isNewTag(acc[row.feature_name], row)) {
this.addTag(acc[row.feature_name], row);
}
@ -838,7 +845,10 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore {
environment: String,
): Promise<void> {
await this.db(T.featureStrategies)
.where({ project_name: projectId, environment })
.where({
project_name: projectId,
environment,
})
.del();
}