chore: remove featureSearchAPI flag (#6081)

frontend/src/interfaces/uiConfig.ts

@@ -64,7 +64,6 @@ export type UiFlags = {
     doraMetrics?: boolean;
     dependentFeatures?: boolean;
     scheduledConfigurationChanges?: boolean;
-    featureSearchAPI?: boolean;
     newStrategyConfiguration?: boolean;
     incomingWebhooks?: boolean;
     automatedActions?: boolean;

src/lib/__snapshots__/create-config.test.ts.snap

@@ -95,7 +95,6 @@ exports[`should create default config 1`] = `
       "executiveDashboard": false,
       "extendedUsageMetrics": false,
       "extendedUsageMetricsUI": false,
-      "featureSearchAPI": true,
       "featureSearchFeedback": false,
       "featureSearchFeedbackPosting": false,
       "featuresExportImport": true,

src/lib/features/feature-search/feature-search-controller.ts

@@ -15,7 +15,6 @@ import {
     searchFeaturesSchema,
 } from '../../openapi';
 import { IAuthRequest } from '../../routes/unleash-types';
-import { InvalidOperationError } from '../../error';
 import {
     FeatureSearchQueryParameters,
     featureSearchQueryParameters,
@@ -75,7 +74,6 @@ export default class FeatureSearchController extends Controller {
         req: IAuthRequest<any, any, any, FeatureSearchQueryParameters>,
         res: Response,
     ): Promise<void> {
-        if (this.config.flagResolver.isEnabled('featureSearchAPI')) {
         const {
             query,
             project,
@@ -131,12 +129,10 @@ export default class FeatureSearchController extends Controller {
             200,
             res,
             searchFeaturesSchema.$id,
-                serializeDates({ features, total }),
-            );
-        } else {
-            throw new InvalidOperationError(
-                'Feature Search API is not enabled',
+            serializeDates({
+                features,
+                total,
+            }),
         );
     }
 }
-}

src/lib/features/feature-search/feature.search.e2e.test.ts

@@ -21,7 +21,6 @@ beforeAll(async () => {
             experimental: {
                 flags: {
                     strictSchemaValidation: true,
-                    featureSearchAPI: true,
                 },
             },
         },

src/lib/types/experimental.ts

@@ -27,7 +27,6 @@ export type IFlagKey =
     | 'filterInvalidClientMetrics'
     | 'customRootRolesKillSwitch'
     | 'disableMetrics'
-    | 'featureSearchAPI'
     | 'scheduledConfigurationChanges'
     | 'detectSegmentUsageInChangeRequests'
     | 'stripClientHeadersOn304'
@@ -130,10 +129,6 @@ const flags: IFlags = {
         process.env.UNLEASH_EXPERIMENTAL_DISABLE_METRICS,
         false,
     ),
-    featureSearchAPI: parseEnvVarBoolean(
-        process.env.UNLEASH_EXPERIMENTAL_FEATURE_SEARCH_API,
-        true,
-    ),
     scheduledConfigurationChanges: parseEnvVarBoolean(
         process.env.UNLEASH_EXPERIMENTAL_SCHEDULED_CONFIGURATION_CHANGES,
         false,

src/server-dev.ts

@@ -40,7 +40,6 @@ process.nextTick(async () => {
                         embedProxyFrontend: true,
                         anonymiseEventLog: false,
                         responseTimeWithAppNameKillSwitch: false,
-                        featureSearchAPI: true,
                         stripClientHeadersOn304: true,
                         newStrategyConfiguration: true,
                         stripHeadersOnAPI: true,