From d8d510be22ae0cb392be0c054050d0d07f866edc Mon Sep 17 00:00:00 2001
From: sighphyre <liquidwicked64@gmail.com>
Date: Tue, 22 Mar 2022 16:00:54 +0200
Subject: [PATCH] fix: change rollout datatype to int

Gradual rollout has the rollout property specified as a string in
both the client spec tests and our API docs and the Rust SDK expects
that contract to be upheld. This commit changes the datatype of rollout
from an int to a string
---
 frontend/cypress/integration/feature/feature.spec.ts        | 4 ++--
 .../StrategyTypes/FlexibleStrategy/FlexibleStrategy.tsx     | 6 +++---
 frontend/src/interfaces/strategy.ts                         | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/frontend/cypress/integration/feature/feature.spec.ts b/frontend/cypress/integration/feature/feature.spec.ts
index 4cd9f31c8d..03162bec0f 100644
--- a/frontend/cypress/integration/feature/feature.spec.ts
+++ b/frontend/cypress/integration/feature/feature.spec.ts
@@ -114,7 +114,7 @@ describe('feature', () => {
                 expect(req.body.name).to.equal('flexibleRollout');
                 expect(req.body.parameters.groupId).to.equal(featureToggleName);
                 expect(req.body.parameters.stickiness).to.equal('default');
-                expect(req.body.parameters.rollout).to.equal(30);
+                expect(req.body.parameters.rollout).to.equal('30');
 
                 if (enterprise) {
                     expect(req.body.constraints.length).to.equal(1);
@@ -160,7 +160,7 @@ describe('feature', () => {
             req => {
                 expect(req.body.parameters.groupId).to.equal('new-group-id');
                 expect(req.body.parameters.stickiness).to.equal('sessionId');
-                expect(req.body.parameters.rollout).to.equal(60);
+                expect(req.body.parameters.rollout).to.equal('60');
 
                 if (enterprise) {
                     expect(req.body.constraints.length).to.equal(1);
diff --git a/frontend/src/component/feature/StrategyTypes/FlexibleStrategy/FlexibleStrategy.tsx b/frontend/src/component/feature/StrategyTypes/FlexibleStrategy/FlexibleStrategy.tsx
index 9ba77a989d..6e4cd08eaa 100644
--- a/frontend/src/component/feature/StrategyTypes/FlexibleStrategy/FlexibleStrategy.tsx
+++ b/frontend/src/component/feature/StrategyTypes/FlexibleStrategy/FlexibleStrategy.tsx
@@ -44,7 +44,7 @@ const FlexibleStrategy = ({
         e: React.ChangeEvent<{}>,
         value: number | number[]
     ) => {
-        updateParameter('rollout', value);
+        updateParameter('rollout', value.toString());
     };
 
     const resolveStickiness = () =>
@@ -62,7 +62,7 @@ const FlexibleStrategy = ({
 
     const stickinessOptions = resolveStickiness();
 
-    const rollout = parameters.rollout !== undefined ? parameters.rollout : 100;
+    const rollout = parameters.rollout !== undefined ? parameters.rollout : '100';
     const stickiness = parameters.stickiness;
     const groupId = parameters.groupId;
 
@@ -70,7 +70,7 @@ const FlexibleStrategy = ({
         <div>
             <RolloutSlider
                 name="Rollout"
-                value={1 * rollout}
+                value={parseInt(rollout)}
                 disabled={!editable}
                 onChange={updateRollout}
             />
diff --git a/frontend/src/interfaces/strategy.ts b/frontend/src/interfaces/strategy.ts
index 3841258135..7408c077e2 100644
--- a/frontend/src/interfaces/strategy.ts
+++ b/frontend/src/interfaces/strategy.ts
@@ -28,7 +28,7 @@ export interface IConstraint {
 
 export interface IParameter {
     groupId?: string;
-    rollout?: number;
+    rollout?: string;
     stickiness?: string;
 
     [index: string]: any;