From d90f0e7a2a65bd2e1a33c4b7ac22e0e270bec8fd Mon Sep 17 00:00:00 2001
From: ivaosthu <ivar.conradi.osthus@finn.no>
Date: Wed, 26 Oct 2016 16:10:55 +0200
Subject: [PATCH] fix warning

---
 .../src/component/error/error-component.jsx         |  1 -
 .../src/component/feature/feature-component.jsx     | 13 ++++++-------
 .../src/component/feature/form/strategies-add.jsx   |  2 +-
 .../component/feature/form/strategy-configure.jsx   |  2 +-
 .../unleash-frontend-next/src/store/error-store.js  |  9 +++++++--
 .../src/store/feature-actions.js                    |  5 +++--
 .../unleash-frontend-next/src/store/feature-api.js  |  3 ++-
 7 files changed, 20 insertions(+), 15 deletions(-)

diff --git a/packages/unleash-frontend-next/src/component/error/error-component.jsx b/packages/unleash-frontend-next/src/component/error/error-component.jsx
index 4d63b5fbff..9bd1d64017 100644
--- a/packages/unleash-frontend-next/src/component/error/error-component.jsx
+++ b/packages/unleash-frontend-next/src/component/error/error-component.jsx
@@ -19,7 +19,6 @@ class ErrorComponent extends React.Component {
                 icon="question_answer"
                 label={snackbarMsg}
                 ref="snackbar"
-                timeout={2000}
                 onClick={this.props.muteErrors}
                 onTimeout={this.props.muteErrors}
                 type="warning"
diff --git a/packages/unleash-frontend-next/src/component/feature/feature-component.jsx b/packages/unleash-frontend-next/src/component/feature/feature-component.jsx
index 15107f01a1..619282c935 100644
--- a/packages/unleash-frontend-next/src/component/feature/feature-component.jsx
+++ b/packages/unleash-frontend-next/src/component/feature/feature-component.jsx
@@ -12,24 +12,23 @@ const Feature = ({ feature, onFeatureClick, onFeatureRemove }) => {
     const { name, description, enabled, strategies } = feature; // eslint-disable-line no-shadow
 
     const actions = [
-        <div>{strategies && strategies.map(s => <Chip><small>{s.name}</small></Chip>)}</div>,
-        <Link to={`/features/edit/${name}`} title={`Edit ${name}`}>
+        <div key="strategies">{strategies && strategies.map((s, i) => <Chip key={i}><small>{s.name}</small></Chip>)}</div>,
+        <Link key="change" to={`/features/edit/${name}`} title={`Edit ${name}`}>
             <FontIcon value="edit" className={style.action} />
         </Link>,
-        <FontIcon className={style.action} value="delete" onClick={() => onFeatureRemove(name)} />,
+        <FontIcon key="delete" className={style.action} value="delete" onClick={() => onFeatureRemove(name)} />,
     ];
 
     const leftActions = [
-        <Switch onChange={() => onFeatureClick(feature)} checked={enabled} />,
+        <Switch key="left-actions" onChange={() => onFeatureClick(feature)} checked={enabled} />,
     ];
 
     return (
         <ListItem
+            key={name}
             leftActions={leftActions}
             rightActions={actions}
-            caption={<Link to={`/features/edit/${name}`} title={`Edit ${name}`} className={style.link}>
-                {name}
-            </Link>}
+            caption={name}
             legend={(description && description.substring(0, 100)) || '-'}
         />
     );
diff --git a/packages/unleash-frontend-next/src/component/feature/form/strategies-add.jsx b/packages/unleash-frontend-next/src/component/feature/form/strategies-add.jsx
index 1da650fdee..b775fa827b 100644
--- a/packages/unleash-frontend-next/src/component/feature/form/strategies-add.jsx
+++ b/packages/unleash-frontend-next/src/component/feature/form/strategies-add.jsx
@@ -41,7 +41,7 @@ class AddStrategy extends React.Component {
 
         return (
         <div style={containerStyle}>
-            <FontIcon value="add" floating mini />
+            <FontIcon value="add" />
             <div style={contentStyle}>
                 <strong>{item.name}</strong>
                 <small>{item.description}</small>
diff --git a/packages/unleash-frontend-next/src/component/feature/form/strategy-configure.jsx b/packages/unleash-frontend-next/src/component/feature/form/strategy-configure.jsx
index ca217cd392..fdef8863ce 100644
--- a/packages/unleash-frontend-next/src/component/feature/form/strategy-configure.jsx
+++ b/packages/unleash-frontend-next/src/component/feature/form/strategy-configure.jsx
@@ -53,7 +53,7 @@ class StrategyConfigure extends React.Component {
 
     render () {
         const leftActions = [
-            <Button onClick={this.handleRemove} icon="remove" floating accent mini />,
+            <Button key="remove" onClick={this.handleRemove} icon="remove" floating accent mini />,
         ];
 
         if (!this.props.strategyDefinition) {
diff --git a/packages/unleash-frontend-next/src/store/error-store.js b/packages/unleash-frontend-next/src/store/error-store.js
index 2c16f5a6f3..c2bccde45d 100644
--- a/packages/unleash-frontend-next/src/store/error-store.js
+++ b/packages/unleash-frontend-next/src/store/error-store.js
@@ -1,6 +1,10 @@
 import { List, Map as $Map } from 'immutable';
-import { ERROR_RECEIVE_FEATURE_TOGGLES } from './feature-actions';
 import { MUTE_ERRORS } from './error-actions';
+import {
+    ERROR_RECEIVE_FEATURE_TOGGLES,
+    ERROR_CREATING_FEATURE_TOGGLE,
+} from './feature-actions';
+
 const debug = require('debug')('unleash:error-store');
 
 function getInitState () {
@@ -12,10 +16,11 @@ function getInitState () {
 
 const strategies = (state = getInitState(), action) => {
     switch (action.type) {
+        case ERROR_CREATING_FEATURE_TOGGLE:
         case ERROR_RECEIVE_FEATURE_TOGGLES:
             debug('Got error', action);
             return state
-                .update('list', (list) => list.push('Failed fetching feature toggles'))
+                .update('list', (list) => list.push(action.errorMsg))
                 .set('showError', true);
         case MUTE_ERRORS:
             debug('muting errors');
diff --git a/packages/unleash-frontend-next/src/store/feature-actions.js b/packages/unleash-frontend-next/src/store/feature-actions.js
index 309e65cb0d..9f6cabdaf1 100644
--- a/packages/unleash-frontend-next/src/store/feature-actions.js
+++ b/packages/unleash-frontend-next/src/store/feature-actions.js
@@ -28,10 +28,11 @@ function updateFeatureToggle (featureToggle) {
     };
 };
 
-function errorCreatingFeatureToggle (statusCode) {
+function errorCreatingFeatureToggle (error) {
     return {
         type: ERROR_CREATING_FEATURE_TOGGLE,
-        statusCode,
+        statusCode: error.statusCode,
+        errorMsg: error.msg,
         receivedAt: Date.now(),
     };
 }
diff --git a/packages/unleash-frontend-next/src/store/feature-api.js b/packages/unleash-frontend-next/src/store/feature-api.js
index 27f3de02eb..7e2b8e4d27 100644
--- a/packages/unleash-frontend-next/src/store/feature-api.js
+++ b/packages/unleash-frontend-next/src/store/feature-api.js
@@ -8,7 +8,8 @@ const headers = {
 function throwIfNotSuccess (response) {
     if (!response.ok) {
         let error = new Error('API call failed');
-        error.status = response.status;
+        error.statusCode = response.status;
+        error.msg = response.json();
         throw error;
     }
     return response;