chore: change from feature flag to using config value for created_by migration

src/lib/__snapshots__/create-config.test.ts.snap

@@ -79,7 +79,6 @@ exports[`should create default config 1`] = `
       "caseInsensitiveInOperators": false,
       "celebrateUnleash": false,
       "collectTrafficDataUsage": false,
-      "createdByUserIdDataMigration": false,
       "demo": false,
       "disableBulkToggle": false,
       "disableMetrics": false,

src/lib/features/events/event-store.ts

@@ -443,10 +443,6 @@ class EventStore implements IEventStore {
     async setCreatedByUserId(batchSize: number): Promise<number | undefined> {
         const API_TOKEN_TABLE = 'api_tokens';
 
-        if (!this.flagResolver.isEnabled('createdByUserIdDataMigration')) {
-            return undefined;
-        }
-
         const toUpdate = await this.db(`${TABLE} as e`)
             .joinRaw(
                 'LEFT OUTER JOIN users AS u ON e.created_by = u.username OR e.created_by = u.email',

src/lib/features/feature-toggle/feature-toggle-store.ts

@@ -730,9 +730,6 @@ export default class FeatureToggleStore implements IFeatureToggleStore {
         const USERS_TABLE = 'users';
         const API_TOKEN_TABLE = 'api_tokens';
 
-        if (!this.flagResolver.isEnabled('createdByUserIdDataMigration')) {
-            return undefined;
-        }
         const toUpdate = await this.db(`${TABLE} as f`)
             .joinRaw(`JOIN ${EVENTS_TABLE} AS ev ON ev.feature_name = f.name`)
             .joinRaw(

src/lib/features/scheduler/schedule-services.ts

@@ -4,6 +4,7 @@ import {
     secondsToMilliseconds,
 } from 'date-fns';
 import type { IUnleashServices } from '../../server-impl';
+import { parseEnvVarBoolean } from '../../util';
 
 /**
  * Schedules service methods.
@@ -154,6 +155,9 @@ export const scheduleServices = async (
         'updateAccountLastSeen',
     );
 
+    if (
+        parseEnvVarBoolean(process.env.CREATED_BY_USERID_DATA_MIGRATION, false)
+    ) {
         schedulerService.schedule(
             eventService.setEventCreatedByUserId.bind(eventService),
             minutesToMilliseconds(2),
@@ -166,4 +170,5 @@ export const scheduleServices = async (
             minutesToMilliseconds(15),
             'setFeatureCreatedByUserIdFromEvents',
         );
+    }
 };

src/lib/types/experimental.ts

@@ -222,10 +222,6 @@ const flags: IFlags = {
                 '',
         },
     },
-    createdByUserIdDataMigration: parseEnvVarBoolean(
-        process.env.CREATED_BY_USERID_DATA_MIGRATION,
-        false,
-    ),
     showInactiveUsers: parseEnvVarBoolean(
         process.env.UNLEASH_EXPERIMENTAL_SHOW_INACTIVE_USERS,
         false,