Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-08-13 13:48:59 +02:00
Code Issues Projects Releases Wiki Activity

chore: change from feature flag to using config value for created_by migration

Browse Source
This commit is contained in:
David Leek 2024-03-22 11:05:21 +01:00
parent ccb067c69c
commit d917645df8
No known key found for this signature in database
GPG Key ID: 515EE0F1BB6D0BE1
5 changed files with 17 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/lib/__snapshots__/create-config.test.ts.snap
View File

@ -79,7 +79,6 @@ exports[`should create default config 1`] = `
"caseInsensitiveInOperators": false, "caseInsensitiveInOperators": false,
"celebrateUnleash": false, "celebrateUnleash": false,
"collectTrafficDataUsage": false, "collectTrafficDataUsage": false,
"createdByUserIdDataMigration": false,
"demo": false, "demo": false,
"disableBulkToggle": false, "disableBulkToggle": false,
"disableMetrics": false, "disableMetrics": false,

4
src/lib/features/events/event-store.ts
View File

@ -443,10 +443,6 @@ class EventStore implements IEventStore {
async setCreatedByUserId(batchSize: number): Promise<number | undefined> { async setCreatedByUserId(batchSize: number): Promise<number | undefined> {
const API_TOKEN_TABLE = 'api_tokens'; const API_TOKEN_TABLE = 'api_tokens';
if (!this.flagResolver.isEnabled('createdByUserIdDataMigration')) {
return undefined;
}
const toUpdate = await this.db(`${TABLE} as e`) const toUpdate = await this.db(`${TABLE} as e`)
.joinRaw( .joinRaw(
'LEFT OUTER JOIN users AS u ON e.created_by = u.username OR e.created_by = u.email', 'LEFT OUTER JOIN users AS u ON e.created_by = u.username OR e.created_by = u.email',

3
src/lib/features/feature-toggle/feature-toggle-store.ts
View File

@ -730,9 +730,6 @@ export default class FeatureToggleStore implements IFeatureToggleStore {
const USERS_TABLE = 'users'; const USERS_TABLE = 'users';
const API_TOKEN_TABLE = 'api_tokens'; const API_TOKEN_TABLE = 'api_tokens';
if (!this.flagResolver.isEnabled('createdByUserIdDataMigration')) {
return undefined;
}
const toUpdate = await this.db(`${TABLE} as f`) const toUpdate = await this.db(`${TABLE} as f`)
.joinRaw(`JOIN ${EVENTS_TABLE} AS ev ON ev.feature_name = f.name`) .joinRaw(`JOIN ${EVENTS_TABLE} AS ev ON ev.feature_name = f.name`)
.joinRaw( .joinRaw(

29
src/lib/features/scheduler/schedule-services.ts
View File

@ -4,6 +4,7 @@ import {
secondsToMilliseconds, secondsToMilliseconds,
} from 'date-fns'; } from 'date-fns';
import type { IUnleashServices } from '../../server-impl'; import type { IUnleashServices } from '../../server-impl';
import { parseEnvVarBoolean } from '../../util';
/** /**
* Schedules service methods. * Schedules service methods.
@ -154,16 +155,20 @@ export const scheduleServices = async (
'updateAccountLastSeen', 'updateAccountLastSeen',
); );
schedulerService.schedule( if (
eventService.setEventCreatedByUserId.bind(eventService), parseEnvVarBoolean(process.env.CREATED_BY_USERID_DATA_MIGRATION, false)
minutesToMilliseconds(2), ) {
'setEventCreatedByUserId', schedulerService.schedule(
); eventService.setEventCreatedByUserId.bind(eventService),
schedulerService.schedule( minutesToMilliseconds(2),
featureToggleService.setFeatureCreatedByUserIdFromEvents.bind( 'setEventCreatedByUserId',
featureToggleService, );
), schedulerService.schedule(
minutesToMilliseconds(15), featureToggleService.setFeatureCreatedByUserIdFromEvents.bind(
'setFeatureCreatedByUserIdFromEvents', featureToggleService,
); ),
minutesToMilliseconds(15),
'setFeatureCreatedByUserIdFromEvents',
);
}
}; };

4
src/lib/types/experimental.ts
View File

@ -222,10 +222,6 @@ const flags: IFlags = {
'', '',
}, },
}, },
createdByUserIdDataMigration: parseEnvVarBoolean(
process.env.CREATED_BY_USERID_DATA_MIGRATION,
false,
),
showInactiveUsers: parseEnvVarBoolean( showInactiveUsers: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_SHOW_INACTIVE_USERS, process.env.UNLEASH_EXPERIMENTAL_SHOW_INACTIVE_USERS,
false, false,