Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-23 00:22:19 +01:00
Code Issues Projects Releases Wiki Activity

feat: remove archive tooltip conditionally (#8702)

Browse Source 
The archived functionality has been moved into the feature list, and we
are showing a tooltip. However, it doesn’t make sense to display it to
new customers, as they wouldn’t be familiar with the previous behavior.

I've introduced a "new/old user" classification, where I’m setting
08.11.2024 as the dividing line. All customers created after 08.11.2024
will be considered new, and we won’t display the tooltip for them.
Everyone else will be treated as old customers.

This approach means there will be a brief period from 08.11.2024 until
the release date where any customers created during this time will be
categorized as new, even if they still have access to the old archive.
For simplicity, I’m willing to accept this risk, as it's likely that in
95% of cases, for those few customers (0–10), they won’t need the
archive functionality immediately, so it’s acceptable not to display the
tooltip for them.

This setup is temporary in our code base and will be removed with a
feature flag.
This commit is contained in:
Jaanus Sellin 2024-11-08 16:12:41 +02:00 committed by GitHub
parent 961501567c
commit da805f2036
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
frontend/src/component/filter/AddFilterButton.tsx
View File

@ -13,6 +13,7 @@ import { HtmlTooltip } from 'component/common/HtmlTooltip/HtmlTooltip';
import useSplashApi from 'hooks/api/actions/useSplashApi/useSplashApi';
import { useAuthSplash } from 'hooks/api/getters/useAuth/useAuthSplash';
import { useOptionalPathParam } from 'hooks/useOptionalPathParam';
import { useAuthUser } from 'hooks/api/getters/useAuth/useAuthUser';
const StyledButton = styled(Button)(({ theme }) => ({
padding: theme.spacing(0, 1.25, 0, 1.25),
@ -49,6 +50,7 @@ export const AddFilterButton = ({
}: IAddFilterButtonProps) => {
const projectId = useOptionalPathParam('projectId');
const simplifyProjectOverview = useUiFlag('simplifyProjectOverview');
const { user } = useAuthUser();
const { setSplashSeen } = useSplashApi();
const { splash } = useAuthSplash();
@ -73,6 +75,15 @@ export const AddFilterButton = ({
handleClose();
};
const isOldCustomer = (createdAt: string | undefined) => {
if (!createdAt) return false;
const cutoffDate = new Date('2024-11-08T00:00:00.000Z');
return new Date(createdAt) < cutoffDate;
};
const showArchiveTooltip =
simplifyProjectOverview && projectId && isOldCustomer(user?.createdAt);
const ArchiveTooltip = () => {
return (
<Box>
@ -97,7 +108,7 @@ export const AddFilterButton = ({
};
return (
<div>
{simplifyProjectOverview && projectId ? (
{showArchiveTooltip ? (
<HtmlTooltip
placement='right'
arrow