Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-07-21 13:47:39 +02:00
Code Issues Projects Releases Wiki Activity

chore: bulk metrics - remove a flag (#10190)

Browse Source
This commit is contained in:
Tymoteusz Czech 2025-06-23 13:25:25 +02:00 committed by GitHub
parent 6aecc3f93e
commit daa6461d9b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 6 additions and 58 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/lib/db/client-instance-store.ts
View File

@ -71,35 +71,6 @@ export default class ClientInstanceStore implements IClientInstanceStore {
}
}
/**
* @deprecated
* `bulkUpsert` is beeing used instead. remove with `lastSeenBulkQuery` flag
*/
async setLastSeen({
appName,
instanceId,
environment,
clientIp,
}: INewClientInstance): Promise<void> {
const stopTimer = this.metricTimer('setLastSeen');
await this.db(TABLE)
.insert({
app_name: appName,
instance_id: instanceId,
environment,
last_seen: new Date(),
client_ip: clientIp,
})
.onConflict(['app_name', 'instance_id', 'environment'])
.merge({
last_seen: new Date(),
client_ip: clientIp,
});
stopTimer();
}
async bulkUpsert(instances: INewClientInstance[]): Promise<void> {
const stopTimer = this.metricTimer('bulkUpsert');

21
src/lib/features/metrics/instance/instance-service.ts
View File

@ -101,21 +101,12 @@ export default class ClientInstanceService {
): Promise<void> {
const value = await clientMetricsSchema.validateAsync(data);
if (this.flagResolver.isEnabled('lastSeenBulkQuery')) {
this.seenClients[this.clientKey(value)] = {
appName: value.appName,
instanceId: value.instanceId,
environment: value.environment,
clientIp: clientIp,
};
} else {
await this.clientInstanceStore.setLastSeen({
appName: value.appName,
instanceId: value.instanceId,
environment: value.environment,
clientIp: clientIp,
});
}
this.seenClients[this.clientKey(value)] = {
appName: value.appName,
instanceId: value.instanceId,
environment: value.environment,
clientIp: clientIp,
};
}
public registerFrontendClient(data: IFrontendClientApp): void {

5
src/lib/types/experimental.ts
View File

@ -56,7 +56,6 @@ export type IFlagKey =
| 'edgeObservability'
| 'registerFrontendClient'
| 'reportUnknownFlags'
| 'lastSeenBulkQuery'
| 'lifecycleMetrics'
| 'customMetrics'
| 'impactMetrics'
@ -267,10 +266,6 @@ const flags: IFlags = {
process.env.UNLEASH_EXPERIMENTAL_REPORT_UNKNOWN_FLAGS,
false,
),
lastSeenBulkQuery: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_LAST_SEEN_BULK_QUERY,
false,
),
lifecycleMetrics: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_LIFECYCLE_METRICS,
false,

5
src/lib/types/stores/client-instance-store.ts
View File

@ -18,11 +18,6 @@ export interface IClientInstanceStore
Pick<INewClientInstance, 'appName' | 'instanceId'>
> {
bulkUpsert(instances: INewClientInstance[]): Promise<void>;
/**
* @deprecated
* `bulkUpsert` is beeing used instead. remove with `lastSeenBulkQuery` flag
*/
setLastSeen(INewClientInstance): Promise<void>;
insert(details: INewClientInstance): Promise<void>;
getByAppName(appName: string): Promise<IClientInstance[]>;
getRecentByAppNameAndEnvironment(

4
src/test/fixtures/fake-client-instance-store.ts vendored
View File

@ -28,10 +28,6 @@ export default class FakeClientInstanceStore implements IClientInstanceStore {
);
}
setLastSeen(): Promise<void> {
return Promise.resolve();
}
async getBySdkName(sdkName: string): Promise<IClientInstance[]> {
return this.instances.filter((instance) =>
instance.sdkVersion?.startsWith(sdkName),