Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

fix: add missing segment-deleted event data (#1677)

Browse Source
This commit is contained in:
olav 2022-06-07 14:06:45 +02:00 committed by GitHub
parent fa74f81aa5
commit dadbc3addc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/services/segment-service.ts
View File

@ -100,7 +100,7 @@ export class SegmentService {
}
async delete(id: number, user: User): Promise<void> {
const segment = this.segmentStore.get(id);
const segment = await this.segmentStore.get(id);
await this.segmentStore.delete(id);
await this.eventStore.store({
type: SEGMENT_DELETED,

16
src/test/e2e/api/client/segment.e2e.test.ts
View File

@ -94,6 +94,7 @@ afterAll(async () => {
afterEach(async () => {
await db.stores.segmentStore.deleteAll();
await db.stores.featureToggleStore.deleteAll();
await db.stores.eventStore.deleteAll();
});
test('should inline segment constraints into features by default', async () => {
@ -225,3 +226,18 @@ test('should only return segments to clients with the segments capability', asyn
expect(collectIds(supportedClientResponse.segments)).toEqual(segmentIds);
expect(supportedClientConstraints.length).toEqual(0);
});
test('should store segment-created and segment-deleted events', async () => {
const constraints = mockConstraints();
const user = new User({ id: 1, email: 'test@example.com' });
await createSegment({ name: 'S1', constraints });
const [segment1] = await fetchSegments();
await app.services.segmentService.delete(segment1.id, user);
const events = await db.stores.eventStore.getEvents();
expect(events[0].type).toEqual('segment-deleted');
expect(events[0].data.id).toEqual(segment1.id);
expect(events[1].type).toEqual('segment-created');
expect(events[1].data.id).toEqual(segment1.id);
});