Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-05-17 01:17:29 +02:00
Code Issues Projects Releases Wiki Activity

chore: consolidate release plan flags (#9606)

Browse Source 
Removes the `releasePlanChangeRequests` flag and swaps existing references to it to the `releasePlans` flag instead
This commit is contained in:
Simon Hornby 2025-03-25 13:36:23 +02:00 committed by GitHub
parent eeb531dd45
commit dbc953b222
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 8 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
frontend/src/component/feature/FeatureStrategy/FeatureStrategyMenu/FeatureStrategyMenu.tsx
View File

@ -71,13 +71,10 @@ export const FeatureStrategyMenu = ({
usePendingChangeRequests(projectId); usePendingChangeRequests(projectId);
const { refetch } = useReleasePlans(projectId, featureId, environmentId); const { refetch } = useReleasePlans(projectId, featureId, environmentId);
const { addReleasePlanToFeature } = useReleasePlansApi(); const { addReleasePlanToFeature } = useReleasePlansApi();
const releasePlanChangeRequestsEnabled = useUiFlag( const releasePlansEnabled = useUiFlag('releasePlans');
'releasePlanChangeRequests',
);
const crProtected = const crProtected =
releasePlanChangeRequestsEnabled && releasePlansEnabled && isChangeRequestConfigured(environmentId);
isChangeRequestConfigured(environmentId);
const onClose = () => { const onClose = () => {
setAnchor(undefined); setAnchor(undefined);

14
frontend/src/component/feature/FeatureView/FeatureOverview/ReleasePlan/LegacyReleasePlan.tsx
View File

@ -119,9 +119,7 @@ export const ReleasePlan = ({
const { refetch: refetchChangeRequests } = const { refetch: refetchChangeRequests } =
usePendingChangeRequests(projectId); usePendingChangeRequests(projectId);
const releasePlanChangeRequestsEnabled = useUiFlag( const releasePlansEnabled = useUiFlag('releasePlans');
'releasePlanChangeRequests',
);
const onAddRemovePlanChangesConfirm = async () => { const onAddRemovePlanChangesConfirm = async () => {
await addChange(projectId, environment, { await addChange(projectId, environment, {
@ -163,10 +161,7 @@ export const ReleasePlan = ({
}; };
const confirmRemoveReleasePlan = () => { const confirmRemoveReleasePlan = () => {
if ( if (releasePlansEnabled && isChangeRequestConfigured(environment)) {
releasePlanChangeRequestsEnabled &&
isChangeRequestConfigured(environment)
) {
setChangeRequestDialogRemoveOpen(true); setChangeRequestDialogRemoveOpen(true);
} else { } else {
setRemoveOpen(true); setRemoveOpen(true);
@ -201,10 +196,7 @@ export const ReleasePlan = ({
}; };
const onStartMilestone = async (milestone: IReleasePlanMilestone) => { const onStartMilestone = async (milestone: IReleasePlanMilestone) => {
if ( if (releasePlansEnabled && isChangeRequestConfigured(environment)) {
releasePlanChangeRequestsEnabled &&
isChangeRequestConfigured(environment)
) {
setMilestoneForChangeRequestDialog(milestone); setMilestoneForChangeRequestDialog(milestone);
setChangeRequestDialogStartMilestoneOpen(true); setChangeRequestDialogStartMilestoneOpen(true);
} else { } else {

14
frontend/src/component/feature/FeatureView/FeatureOverview/ReleasePlan/ReleasePlan.tsx
View File

@ -122,9 +122,7 @@ export const ReleasePlan = ({
const { refetch: refetchChangeRequests } = const { refetch: refetchChangeRequests } =
usePendingChangeRequests(projectId); usePendingChangeRequests(projectId);
const releasePlanChangeRequestsEnabled = useUiFlag( const releasePlansEnabled = useUiFlag('releasePlans');
'releasePlanChangeRequests',
);
const onAddRemovePlanChangesConfirm = async () => { const onAddRemovePlanChangesConfirm = async () => {
await addChange(projectId, environment, { await addChange(projectId, environment, {
@ -166,10 +164,7 @@ export const ReleasePlan = ({
}; };
const confirmRemoveReleasePlan = () => { const confirmRemoveReleasePlan = () => {
if ( if (releasePlansEnabled && isChangeRequestConfigured(environment)) {
releasePlanChangeRequestsEnabled &&
isChangeRequestConfigured(environment)
) {
setChangeRequestDialogRemoveOpen(true); setChangeRequestDialogRemoveOpen(true);
} else { } else {
setRemoveOpen(true); setRemoveOpen(true);
@ -204,10 +199,7 @@ export const ReleasePlan = ({
}; };
const onStartMilestone = async (milestone: IReleasePlanMilestone) => { const onStartMilestone = async (milestone: IReleasePlanMilestone) => {
if ( if (releasePlansEnabled && isChangeRequestConfigured(environment)) {
releasePlanChangeRequestsEnabled &&
isChangeRequestConfigured(environment)
) {
setMilestoneForChangeRequestDialog(milestone); setMilestoneForChangeRequestDialog(milestone);
setChangeRequestDialogStartMilestoneOpen(true); setChangeRequestDialogStartMilestoneOpen(true);
} else { } else {

1
frontend/src/interfaces/uiConfig.ts
View File

@ -84,7 +84,6 @@ export type UiFlags = {
enableLegacyVariants?: boolean; enableLegacyVariants?: boolean;
flagCreator?: boolean; flagCreator?: boolean;
releasePlans?: boolean; releasePlans?: boolean;
releasePlanChangeRequests?: boolean;
'enterprise-payg'?: boolean; 'enterprise-payg'?: boolean;
productivityReportEmail?: boolean; productivityReportEmail?: boolean;
showUserDeviceCount?: boolean; showUserDeviceCount?: boolean;

5
src/lib/types/experimental.ts
View File

@ -50,7 +50,6 @@ export type IFlagKey =
| 'originMiddlewareRequestLogging' | 'originMiddlewareRequestLogging'
| 'webhookDomainLogging' | 'webhookDomainLogging'
| 'releasePlans' | 'releasePlans'
| 'releasePlanChangeRequests'
| 'productivityReportEmail' | 'productivityReportEmail'
| 'productivityReportUnsubscribers' | 'productivityReportUnsubscribers'
| 'enterprise-payg' | 'enterprise-payg'
@ -255,10 +254,6 @@ const flags: IFlags = {
process.env.UNLEASH_EXPERIMENTAL_RELEASE_PLANS, process.env.UNLEASH_EXPERIMENTAL_RELEASE_PLANS,
false, false,
), ),
releasePlanChangeRequests: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_RELEASE_PLAN_CHANGE_REQUESTS,
false,
),
productivityReportEmail: parseEnvVarBoolean( productivityReportEmail: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_PRODUCTIVITY_REPORT_EMAIL, process.env.UNLEASH_EXPERIMENTAL_PRODUCTIVITY_REPORT_EMAIL,
false, false,

1
src/server-dev.ts
View File

@ -50,7 +50,6 @@ process.nextTick(async () => {
originMiddlewareRequestLogging: true, originMiddlewareRequestLogging: true,
webhookDomainLogging: true, webhookDomainLogging: true,
releasePlans: false, releasePlans: false,
releasePlanChangeRequests: false,
showUserDeviceCount: true, showUserDeviceCount: true,
flagOverviewRedesign: true, flagOverviewRedesign: true,
deltaApi: true, deltaApi: true,