Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

fix: lint

Browse Source
This commit is contained in:
FredrikOseberg 2025-10-22 12:18:47 +02:00
parent 2ee3a62808
commit de4d7db2ef
No known key found for this signature in database
GPG Key ID: 282FD8A6D8F9BCF0
5 changed files with 10 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
frontend/src/component/changeRequest/ChangeRequest/Changes/Change/ConsolidatedProgressionChanges.tsx
View File

@ -17,7 +17,7 @@ import {
} from './Change.styles.tsx';
import type { UpdateMilestoneProgressionSchema } from 'openapi';
import { MilestoneListRenderer } from './MilestoneListRenderer.tsx';
import { applyProgressionChanges } from './applyProgressionChanges';
import { applyProgressionChanges } from './applyProgressionChanges.js';
import { EventDiff } from 'component/events/EventDiff/EventDiff';
const StyledTabs = styled(Tabs)(({ theme }) => ({
@ -139,15 +139,6 @@ export const ConsolidatedProgressionChanges: FC<{
basePlan,
);
const basePlanWithDeletedAutomations: IReleasePlan = {
...basePlan,
milestones: basePlan.milestones.map((milestone) =>
milestonesWithDeletedAutomation.has(milestone.id)
? milestone
: milestone,
),
};
return (
<StyledTabs>
<ChangeItemWrapper>
@ -173,11 +164,7 @@ export const ConsolidatedProgressionChanges: FC<{
</ChangeItemWrapper>
<TabPanel>
<MilestoneListRenderer
plan={
milestonesWithDeletedAutomation.size > 0
? basePlanWithDeletedAutomations
: modifiedPlan
}
plan={modifiedPlan}
changeRequestState={changeRequestState}
milestonesWithAutomation={milestonesWithAutomation}
milestonesWithDeletedAutomation={

1
frontend/src/component/changeRequest/ChangeRequest/Changes/Change/MilestoneListRenderer.tsx
View File

@ -35,6 +35,7 @@ export const MilestoneListRenderer = ({
onUpdateAutomation,
onDeleteAutomation,
}: MilestoneListRendererProps) => {
// TODO: Split into read and write model at the type level to avoid having optional handlers
const readonly =
changeRequestState === 'Applied' || changeRequestState === 'Cancelled';
const status: MilestoneStatus = 'not-started';

1
frontend/src/component/changeRequest/ChangeRequest/Changes/Change/ReleasePlanChange.tsx
View File

@ -338,6 +338,7 @@ export const ReleasePlanChange: FC<{
// Only render if this is the first progression change
const isFirstProgression =
progressionChanges.length > 0 && progressionChanges[0] === change;
if (!isFirstProgression) {
return null; // Skip rendering, will be handled by the first one
}

9
frontend/src/component/feature/FeatureView/FeatureOverview/ReleasePlan/ReleasePlanMilestoneItem/ReleasePlanMilestoneItem.tsx
View File

@ -10,9 +10,9 @@ import { useMilestoneProgressionsApi } from 'hooks/api/actions/useMilestoneProgr
import { useChangeRequestsEnabled } from 'hooks/useChangeRequestsEnabled';
import useToast from 'hooks/useToast';
import { formatUnknownError } from 'utils/formatUnknownError';
import { calculateMilestoneStatus } from './milestoneStatusUtils';
import { usePendingProgressionChanges } from './usePendingProgressionChanges';
import { MilestoneAutomation } from './MilestoneAutomation';
import { calculateMilestoneStatus } from './milestoneStatusUtils.js';
import { usePendingProgressionChanges } from './usePendingProgressionChanges.js';
import { MilestoneAutomation } from './MilestoneAutomation.tsx';
const StyledConnection = styled('div', {
shouldForwardProp: (prop) => prop !== 'isCompleted',
@ -171,7 +171,8 @@ export const ReleasePlanMilestoneItem = ({
const { pendingProgressionChange, effectiveTransitionCondition } =
usePendingProgressionChanges(milestone, getPendingProgressionChange);
const shouldShowAutomation = isNotLastMilestone && milestoneProgressionsEnabled;
const shouldShowAutomation =
isNotLastMilestone && milestoneProgressionsEnabled;
const automationSection = shouldShowAutomation ? (
<MilestoneAutomation

2
frontend/src/component/feature/FeatureView/FeatureOverview/ReleasePlan/ReleasePlanMilestoneItem/usePendingProgressionChanges.ts
View File

@ -2,7 +2,7 @@ import type { IReleasePlanMilestone } from 'interfaces/releasePlans';
import type {
IReleasePlanMilestoneItemProps,
PendingProgressionChange,
} from './ReleasePlanMilestoneItem';
} from './ReleasePlanMilestoneItem.jsx';
interface PendingProgressionChangeResult {
pendingProgressionChange: PendingProgressionChange | null;