Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2024-12-22 19:07:54 +01:00
Code Issues Projects Releases Wiki Activity

fix: segment project fetch when global (#5311)

Browse Source 
This fixes an edge case not caught originally in
https://github.com/Unleash/unleash/pull/5304 - When creating a new
segment on the global level:
 - There is no `projectId`, either in the params or body
- The `UPDATE_PROJECT_SEGMENT` is still a part of the permissions
checked on the endpoint
 - There is no `id` on the params

This made it so that we would run `segmentStore.get(id)` with an
undefined `id`, causing issues.

The fix was simply checking for the presence of `params.id` before
proceeding.
This commit is contained in:
Nuno Góis 2023-11-09 13:27:12 +00:00 committed by GitHub
parent 100c22b42a
commit de638b5b8e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/middleware/rbac-middleware.ts
View File

@ -3,7 +3,6 @@ import {
DELETE_FEATURE, DELETE_FEATURE,
ADMIN, ADMIN,
UPDATE_FEATURE, UPDATE_FEATURE,
DELETE_SEGMENT,
UPDATE_PROJECT_SEGMENT, UPDATE_PROJECT_SEGMENT,
} from '../types/permissions'; } from '../types/permissions';
import { IUnleashConfig } from '../types/option'; import { IUnleashConfig } from '../types/option';
@ -96,7 +95,8 @@ const rbacMiddleware = (
// This is needed to check if the user has the right permissions on a project level // This is needed to check if the user has the right permissions on a project level
if ( if (
!projectId && !projectId &&
permissionsArray.includes(UPDATE_PROJECT_SEGMENT) permissionsArray.includes(UPDATE_PROJECT_SEGMENT) &&
params.id
) { ) {
const { id } = params; const { id } = params;
const { project } = await segmentStore.get(id); const { project } = await segmentStore.get(id);