fix: convert more tests to typescript

package.json

@@ -116,6 +116,7 @@
     "@types/bcrypt": "^5.0.0",
     "@types/express": "^4.17.11",
     "@types/express-session": "^1.17.4",
+    "@types/faker": "^5.5.8",
     "@types/jest": "^27.0.1",
     "@types/js-yaml": "^3.12.7",
     "@types/memoizee": "^0.4.6",

src/lib/logger.test.ts

@@ -1,6 +1,4 @@
-'use strict';
+import * as logger from './logger';
-
-const logger = require('./logger');
 
 test('should require custom logger to implement info', () => {
     const loggerImpl = {
@@ -10,7 +8,8 @@ test('should require custom logger to implement info', () => {
     };
     const provider = () => loggerImpl;
     expect(() => {
-        logger.validateLogProvider(provider)();
+        // @ts-ignore:next-line
+        return logger.validateLogProvider(provider);
     }).toThrowError(new TypeError('Logger must implement info'));
 });
 
@@ -22,6 +21,7 @@ test('should require custom logger to implement error', () => {
     };
     const provider = () => loggerImpl;
     expect(() => {
-        logger.validateLogProvider(provider)();
+        // @ts-ignore:next-line
+        return logger.validateLogProvider(provider);
     }).toThrowError(new TypeError('Logger must implement error'));
 });

src/lib/server-impl.test.ts

@@ -1,8 +1,7 @@
-'use strict';
+import { EventEmitter } from 'events';
-
+import express from 'express';
-const { EventEmitter } = require('events');
+import { createTestConfig } from '../test/config/test-config';
-const express = require('express');
+import { start, create } from './server-impl';
-const { createTestConfig } = require('../test/config/test-config');
 
 jest.mock(
     './routes',
@@ -14,8 +13,6 @@ jest.mock(
         },
 );
 
-const getApp = require('./app');
-
 const noop = () => {};
 
 const eventStore = new EventEmitter();
@@ -25,8 +22,6 @@ const settingStore = {
     },
 };
 
-jest.mock('./app', () => getApp);
-
 jest.mock('./metrics', () => ({
     createMetricsMonitor() {
         return {
@@ -60,8 +55,6 @@ jest.mock(
         },
 );
 
-const serverImpl = require('./server-impl');
-
 test('should call preHook', async () => {
     let called = 0;
     const config = createTestConfig({
@@ -70,13 +63,14 @@ test('should call preHook', async () => {
             called++;
         },
     });
-    await serverImpl.start(config);
+    const { stop } = await start(config);
     expect(called).toBe(1);
+    await stop();
 });
 
 test('should call preRouterHook', async () => {
     let called = 0;
-    await serverImpl.start(
+    const { stop } = await start(
         createTestConfig({
             server: { port: 0 },
             preRouterHook: () => {
@@ -85,6 +79,7 @@ test('should call preRouterHook', async () => {
         }),
     );
     expect(called === 1).toBe(true);
+    await stop();
 });
 
 test('should call eventHook', async () => {
@@ -95,26 +90,29 @@ test('should call eventHook', async () => {
             called++;
         },
     });
-    await serverImpl.start(config);
+    const { stop } = await start(config);
     eventStore.emit('feature-created', {});
     expect(called === 1).toBe(true);
+    await stop();
 });
 
 test('should auto-create server on start()', async () => {
-    const { server } = await serverImpl.start(
+    const { server, stop } = await start(
         createTestConfig({ server: { port: 0 } }),
     );
     expect(typeof server === 'undefined').toBe(false);
+    await stop();
 });
 
 test('should not create a server using create()', async () => {
     const config = createTestConfig({ server: { port: 0 } });
-    const { server } = await serverImpl.create(config);
+    const { server, stop } = await create(config);
     expect(server).toBeUndefined();
+    await stop();
 });
 
 test('should shutdown the server when calling stop()', async () => {
-    const { server, stop } = await serverImpl.start(
+    const { server, stop } = await start(
         createTestConfig({ server: { port: 0 } }),
     );
     await stop();

src/test/e2e/api/client/metrics.e2e.test.ts

@@ -1,9 +1,7 @@
-'use strict';
+import { setupApp } from '../../helpers/test-helper';
-
+import metricsExample from '../../../examples/client-metrics.json';
-const { setupApp } = require('../../helpers/test-helper');
+import dbInit from '../../helpers/database-init';
-const metricsExample = require('../../../examples/client-metrics.json');
+import getLogger from '../../../fixtures/no-logger';
-const dbInit = require('../../helpers/database-init');
-const getLogger = require('../../../fixtures/no-logger');
 
 let app;
 let db;

src/test/e2e/api/client/register.e2e.test.ts

@@ -1,10 +1,8 @@
-'use strict';
+import faker from 'faker';
-
+import { setupApp } from '../../helpers/test-helper';
-const faker = require('faker');
+import dbInit from '../../helpers/database-init';
-const { setupApp } = require('../../helpers/test-helper');
+import getLogger from '../../../fixtures/no-logger';
-const dbInit = require('../../helpers/database-init');
+import version from '../../../../lib/util/version';
-const getLogger = require('../../../fixtures/no-logger');
-const version = require('../../../../lib/util/version');
 
 const asyncFilter = async (arr, predicate) => {
     const results = await Promise.all(arr.map(predicate));

yarn.lock

@@ -744,6 +744,11 @@
     "@types/qs" "*"
     "@types/serve-static" "*"
 
+"@types/faker@^5.5.8":
+  version "5.5.8"
+  resolved "https://registry.yarnpkg.com/@types/faker/-/faker-5.5.8.tgz#6649adfdfdbb0acf95361fc48f2d0ca6e88bd1cf"
+  integrity sha512-bsl0rYsaZVHlZkynL5O04q6YXDmVjcid6MbOHWqvtE2WWs/EKhp0qchDDhVWlWyQXUffX1G83X9LnMxRl8S/Mw==
+
 "@types/graceful-fs@^4.1.2":
   version "4.1.5"
   resolved "https://registry.npmjs.org/@types/graceful-fs/-/graceful-fs-4.1.5.tgz"