Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

fix: return 400 on invalid JSON instead of 404 (#1897)

Browse Source
This commit is contained in:
olav 2022-08-08 14:44:57 +02:00 committed by GitHub
parent d4b9ca443c
commit df910cc20c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/services/openapi-service.ts
View File

@ -59,7 +59,7 @@ export class OpenApiService {
validation: err.validationErrors, validation: err.validationErrors,
}); });
} else { } else {
next(); next(err);
} }
}); });
} }

9
src/test/e2e/api/admin/feature.e2e.test.ts
View File

@ -340,6 +340,15 @@ test('require new feature toggle to have a name', async () => {
.expect(400); .expect(400);
}); });
test('should return 400 on invalid JSON data', async () => {
expect.assertions(0);
return app.request
.post('/api/admin/features')
.send(`{ invalid-json }`)
.set('Content-Type', 'application/json')
.expect(400);
});
test('can not change status of feature toggle that does not exist', async () => { test('can not change status of feature toggle that does not exist', async () => {
expect.assertions(0); expect.assertions(0);
return app.request return app.request