From e140ab63e1a730775f589ad1d07e70a6a9b6a3bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gast=C3=B3n=20Fournier?= Date: Tue, 22 Jul 2025 13:42:14 +0200 Subject: [PATCH] fix: flaky delete stale session (#10387) When deleting stale sessions, we sort them by createdAt. If both sessions are created with the same createdAt, there's a chance we get a different sort order and we end up with the wrong order: https://github.com/Unleash/unleash/actions/runs/16438565746/job/46453700977 I think adding 10ms between inserts should be enough (1ms should do, but this gives me more confidence and doesn't hurt that much) --------- Co-authored-by: Thomas Heartman --- src/test/e2e/services/session-service.e2e.test.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/e2e/services/session-service.e2e.test.ts b/src/test/e2e/services/session-service.e2e.test.ts index 776328db5d..bc7b47cdf0 100644 --- a/src/test/e2e/services/session-service.e2e.test.ts +++ b/src/test/e2e/services/session-service.e2e.test.ts @@ -114,6 +114,7 @@ test('Can delete session by sid', async () => { test('Can delete stale sessions', async () => { await sessionService.insertSession(newSession); + await new Promise((resolve) => setTimeout(resolve, 10)); // Ensure a different createdAt await sessionService.insertSession({ ...newSession, sid: 'new' }); const sessionsToKeep = 1;