1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-14 00:19:16 +01:00

feat: separate UI flag and backend flag for extended metrics (#5875)

This commit is contained in:
Mateusz Kwasniewski 2024-01-12 10:20:03 +01:00 committed by GitHub
parent b1d7c27124
commit e27a578fab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 11 additions and 4 deletions

View File

@ -9,7 +9,7 @@ const server = testServerSetup();
test('Display extended daily metrics', async () => {
testServerRoute(server, '/api/admin/ui-config', {
flags: {
extendedUsageMetrics: true,
extendedUsageMetricsUI: true,
},
versionInfo: {
current: { oss: 'irrelevant', enterprise: 'some value' },

View File

@ -29,7 +29,7 @@ export const FeatureMetricsHours = ({
setHoursBack(parseInt(key));
};
const { isEnterprise } = useUiConfig();
const extendedUsageMetrics = useUiFlag('extendedUsageMetrics');
const extendedUsageMetrics = useUiFlag('extendedUsageMetricsUI');
const extendedOptions = isEnterprise() && extendedUsageMetrics;
const options = extendedOptions
? [...hourOptions, ...daysOptions]

View File

@ -73,7 +73,7 @@ export type UiFlags = {
featureSearchFeedback?: boolean;
enableLicense?: boolean;
newStrategyConfigurationFeedback?: boolean;
extendedUsageMetrics?: boolean;
extendedUsageMetricsUI?: boolean;
};
export interface IVersionInfo {

View File

@ -88,6 +88,7 @@ exports[`should create default config 1`] = `
"enableLicense": false,
"encryptEmails": false,
"extendedUsageMetrics": false,
"extendedUsageMetricsUI": false,
"featureSearchAPI": false,
"featureSearchFeedback": false,
"featureSearchFeedbackPosting": false,

View File

@ -41,7 +41,8 @@ export type IFlagKey =
| 'featureSearchFeedbackPosting'
| 'newStrategyConfigurationFeedback'
| 'edgeBulkMetricsKillSwitch'
| 'extendedUsageMetrics';
| 'extendedUsageMetrics'
| 'extendedUsageMetricsUI';
export type IFlags = Partial<{ [key in IFlagKey]: boolean | Variant }>;
@ -188,6 +189,10 @@ const flags: IFlags = {
process.env.UNLEASH_EXPERIMENTAL_EXTENDED_USAGE_METRICS,
false,
),
extendedUsageMetricsUI: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_EXTENDED_USAGE_METRICS_UI,
false,
),
};
export const defaultExperimentalOptions: IExperimentalOptions = {

View File

@ -49,6 +49,7 @@ process.nextTick(async () => {
increaseUnleashWidth: true,
featureSearchFeedback: true,
newStrategyConfigurationFeedback: true,
extendedUsageMetricsUI: true,
},
},
authentication: {