Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-19 00:15:43 +01:00
Code Issues Projects Releases Wiki Activity

feat: separate UI flag and backend flag for extended metrics (#5875)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2024-01-12 10:20:03 +01:00 committed by GitHub
parent b1d7c27124
commit e27a578fab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/component/feature/FeatureView/FeatureMetrics/FeatureMetricsHours/FeatureMetricsHours.test.tsx
View File

@ -9,7 +9,7 @@ const server = testServerSetup();
test('Display extended daily metrics', async () => { test('Display extended daily metrics', async () => {
testServerRoute(server, '/api/admin/ui-config', { testServerRoute(server, '/api/admin/ui-config', {
flags: { flags: {
extendedUsageMetrics: true, extendedUsageMetricsUI: true,
}, },
versionInfo: { versionInfo: {
current: { oss: 'irrelevant', enterprise: 'some value' }, current: { oss: 'irrelevant', enterprise: 'some value' },

2
frontend/src/component/feature/FeatureView/FeatureMetrics/FeatureMetricsHours/FeatureMetricsHours.tsx
View File

@ -29,7 +29,7 @@ export const FeatureMetricsHours = ({
setHoursBack(parseInt(key)); setHoursBack(parseInt(key));
}; };
const { isEnterprise } = useUiConfig(); const { isEnterprise } = useUiConfig();
const extendedUsageMetrics = useUiFlag('extendedUsageMetrics'); const extendedUsageMetrics = useUiFlag('extendedUsageMetricsUI');
const extendedOptions = isEnterprise() && extendedUsageMetrics; const extendedOptions = isEnterprise() && extendedUsageMetrics;
const options = extendedOptions const options = extendedOptions
? [...hourOptions, ...daysOptions] ? [...hourOptions, ...daysOptions]

2
frontend/src/interfaces/uiConfig.ts
View File

@ -73,7 +73,7 @@ export type UiFlags = {
featureSearchFeedback?: boolean; featureSearchFeedback?: boolean;
enableLicense?: boolean; enableLicense?: boolean;
newStrategyConfigurationFeedback?: boolean; newStrategyConfigurationFeedback?: boolean;
extendedUsageMetrics?: boolean; extendedUsageMetricsUI?: boolean;
}; };
export interface IVersionInfo { export interface IVersionInfo {

1
src/lib/__snapshots__/create-config.test.ts.snap
View File

@ -88,6 +88,7 @@ exports[`should create default config 1`] = `
"enableLicense": false, "enableLicense": false,
"encryptEmails": false, "encryptEmails": false,
"extendedUsageMetrics": false, "extendedUsageMetrics": false,
"extendedUsageMetricsUI": false,
"featureSearchAPI": false, "featureSearchAPI": false,
"featureSearchFeedback": false, "featureSearchFeedback": false,
"featureSearchFeedbackPosting": false, "featureSearchFeedbackPosting": false,

7
src/lib/types/experimental.ts
View File

@ -41,7 +41,8 @@ export type IFlagKey =
| 'featureSearchFeedbackPosting' | 'featureSearchFeedbackPosting'
| 'newStrategyConfigurationFeedback' | 'newStrategyConfigurationFeedback'
| 'edgeBulkMetricsKillSwitch' | 'edgeBulkMetricsKillSwitch'
| 'extendedUsageMetrics'; | 'extendedUsageMetrics'
| 'extendedUsageMetricsUI';
export type IFlags = Partial<{ [key in IFlagKey]: boolean | Variant }>; export type IFlags = Partial<{ [key in IFlagKey]: boolean | Variant }>;
@ -188,6 +189,10 @@ const flags: IFlags = {
process.env.UNLEASH_EXPERIMENTAL_EXTENDED_USAGE_METRICS, process.env.UNLEASH_EXPERIMENTAL_EXTENDED_USAGE_METRICS,
false, false,
), ),
extendedUsageMetricsUI: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_EXTENDED_USAGE_METRICS_UI,
false,
),
}; };
export const defaultExperimentalOptions: IExperimentalOptions = { export const defaultExperimentalOptions: IExperimentalOptions = {

1
src/server-dev.ts
View File

@ -49,6 +49,7 @@ process.nextTick(async () => {
increaseUnleashWidth: true, increaseUnleashWidth: true,
featureSearchFeedback: true, featureSearchFeedback: true,
newStrategyConfigurationFeedback: true, newStrategyConfigurationFeedback: true,
extendedUsageMetricsUI: true,
}, },
}, },
authentication: { authentication: {