Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

Hard cap expiry date of public signup token (#2308)

Browse Source 
Validate expiry
This commit is contained in:
sjaanus 2022-11-01 10:38:18 +01:00 committed by GitHub
parent c501fb221c
commit e3a185d650
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 44 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/lib/services/public-signup-token-service.ts
View File

@ -17,6 +17,7 @@ import {
import UserService from './user-service';
import { IUser } from '../types/user';
import { URL } from 'url';
import { add } from 'date-fns';
export class PublicSignupTokenService {
private store: IPublicSignupTokenStore;
@ -118,9 +119,13 @@ export class PublicSignupTokenService {
const viewerRole = await this.roleStore.getRoleByName(RoleName.VIEWER);
const secret = this.generateSecretKey();
const url = this.getUrl(secret);
const cappedDate = this.getMinimumDate(
new Date(tokenCreate.expiresAt),
add(new Date(), { months: 1 }),
);
const newToken: IPublicSignupTokenCreate = {
name: tokenCreate.name,
expiresAt: new Date(tokenCreate.expiresAt),
expiresAt: cappedDate,
secret: secret,
roleId: viewerRole ? viewerRole.id : -1,
createdBy: createdBy,
@ -141,6 +146,10 @@ export class PublicSignupTokenService {
return crypto.randomBytes(16).toString('hex');
}
private getMinimumDate(date1: Date, date2: Date): Date {
return date1 < date2 ? date1 : date2;
}
destroy(): void {
clearInterval(this.timer);
this.timer = null;

34
src/test/e2e/api/admin/public-signup-token.e2e.test.ts
View File

@ -214,3 +214,37 @@ test('can get a token with users', async () => {
await destroy();
});
test('should not be able to set expiry further than 1 month', async () => {
const preHook = (app, config, { userService, accessService }) => {
app.use('/api/admin/', async (req, res, next) => {
const role = await accessService.getRootRole(RoleName.ADMIN);
const user = await userService.createUser({
email: 'admin@example.com',
rootRole: role.id,
});
req.user = user;
next();
});
};
const { request, destroy } = await setupAppWithCustomAuth(stores, preHook);
const tokenCreate: PublicSignupTokenCreateSchema = {
name: 'some-name',
expiresAt: expireAt(100).toISOString(),
};
await request
.post('/api/admin/invite-link/tokens')
.send(tokenCreate)
.expect('Content-Type', /json/)
.expect(201)
.expect((res) => {
expect(new Date(res.body.expiresAt).getTime()).toBeLessThan(
expireAt(31).getTime(),
);
});
await destroy();
});