feat: remove instances older than 1 day not 2 days (#9944)

src/lib/db/client-instance-store.ts

@@ -61,9 +61,9 @@ export default class ClientInstanceStore implements IClientInstanceStore {
             });
     }
 
-    async removeInstancesOlderThanTwoDays(): Promise<void> {
+    async removeOldInstances(): Promise<void> {
         const rows = await this.db(TABLE)
-            .whereRaw("last_seen < now() - interval '2 days'")
+            .whereRaw("last_seen < now() - interval '1 days'")
             .del();
 
         if (rows > 0) {

src/lib/features/metrics/instance/instance-service.ts

@@ -316,8 +316,8 @@ export default class ClientInstanceService {
         await this.clientApplicationsStore.upsert(input);
     }
 
-    async removeInstancesOlderThanTwoDays(): Promise<void> {
+    async removeOldInstances(): Promise<void> {
-        return this.clientInstanceStore.removeInstancesOlderThanTwoDays();
+        return this.clientInstanceStore.removeOldInstances();
     }
 
     async removeInactiveApplications(): Promise<number> {

src/lib/features/scheduler/schedule-services.ts

@@ -72,9 +72,7 @@ export const scheduleServices = async (
     );
 
     schedulerService.schedule(
-        clientInstanceService.removeInstancesOlderThanTwoDays.bind(
+        clientInstanceService.removeOldInstances.bind(clientInstanceService),
-            clientInstanceService,
-        ),
         hoursToMilliseconds(24),
         'removeInstancesOlderThanTwoDays',
     );

src/lib/types/stores/client-instance-store.ts

@@ -35,5 +35,5 @@ export interface IClientInstanceStore
     getDistinctApplications(): Promise<string[]>;
     getDistinctApplicationsCount(daysBefore?: number): Promise<number>;
     deleteForApplication(appName: string): Promise<void>;
-    removeInstancesOlderThanTwoDays(): Promise<void>;
+    removeOldInstances(): Promise<void>;
 }

src/test/fixtures/fake-client-instance-store.ts

@@ -117,7 +117,7 @@ export default class FakeClientInstanceStore implements IClientInstanceStore {
         this.instances.push({ createdAt: new Date(), ...details });
     }
 
-    removeInstancesOlderThanTwoDays(): Promise<void> {
+    removeOldInstances(): Promise<void> {
         return Promise.resolve(undefined);
     }
 }