From e5a5d7ded963875bfb82071e64fd782c67f633d0 Mon Sep 17 00:00:00 2001 From: sjaanus Date: Thu, 10 Nov 2022 13:27:09 +0100 Subject: [PATCH] Fix async issue (#2387) Currently rows were returned as a list of promise, but we need to await for them. --- src/lib/db/project-store.ts | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/lib/db/project-store.ts b/src/lib/db/project-store.ts index 2476e42b1d..089446d955 100644 --- a/src/lib/db/project-store.ts +++ b/src/lib/db/project-store.ts @@ -259,14 +259,17 @@ class ProjectStore implements IProjectStore { environment: string, projects: string[], ): Promise { - const rows = projects.map(async (projectId) => { - const project = await this.get(projectId); - return { - project_id: projectId, - environment_name: environment, - change_request_enabled: project.changeRequestsEnabled || false, - }; - }); + const rows = await Promise.all( + projects.map(async (projectId) => { + const project = await this.get(projectId); + return { + project_id: projectId, + environment_name: environment, + change_request_enabled: + project.changeRequestsEnabled || false, + }; + }), + ); await this.db('project_environments') .insert(rows)