From e5be1bf43e2b18b820d0ef7061f7317cea98030d Mon Sep 17 00:00:00 2001 From: Thomas Heartman Date: Thu, 6 Mar 2025 15:11:48 +0100 Subject: [PATCH] Fix: drag and drop reverts to previous position on drop (#9439) Fixes an issue where, when dragging large expanded milestone cards, the position would revert from the current visual state to the previous one when you drop the item. --- .../TemplateForm/MilestoneList/MilestoneList.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frontend/src/component/releases/ReleasePlanTemplate/TemplateForm/MilestoneList/MilestoneList.tsx b/frontend/src/component/releases/ReleasePlanTemplate/TemplateForm/MilestoneList/MilestoneList.tsx index d235d2aad3..2929c9964c 100644 --- a/frontend/src/component/releases/ReleasePlanTemplate/TemplateForm/MilestoneList/MilestoneList.tsx +++ b/frontend/src/component/releases/ReleasePlanTemplate/TemplateForm/MilestoneList/MilestoneList.tsx @@ -32,7 +32,11 @@ export const MilestoneList = ({ }: IMilestoneListProps) => { const useNewMilestoneCard = useUiFlag('flagOverviewRedesign'); const onMoveItem: OnMoveItem = useCallback( - async (dragIndex: number, dropIndex: number) => { + async (dragIndex: number, dropIndex: number, save?: boolean) => { + if (useNewMilestoneCard && save) { + return; // the user has let go, we should leave the current sort order as it is currently visually displayed + } + if (dragIndex !== dropIndex) { const oldMilestones = milestones || []; const newMilestones = [...oldMilestones];