Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2024-10-18 20:09:08 +02:00
Code Issues Projects Releases Wiki Activity

Fix variant list

Browse Source 
- Fix an issue where clicking a variant in the list would popup a modal
dialog with empty details
This commit is contained in:
Simon Hornby 2021-11-25 16:02:38 +02:00
parent b69606cd98
commit e5c941c68d
1 changed files with 23 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
frontend/src/component/feature/FeatureView2/FeatureVariants/FeatureVariantsList/FeatureVariantsListItem/FeatureVariantsListItem.tsx
View File

@ -23,7 +23,12 @@ const FeatureVariantListItem = ({
return (
<TableRow>
<TableCell onClick={editVariant} data-test={'VARIANT_NAME'}>{variant.name}</TableCell>
<TableCell
onClick={() => editVariant(variant.name)}
data-test={'VARIANT_NAME'}
>
{variant.name}
</TableCell>
<TableCell className={styles.chipContainer}>
<ConditionallyRender
condition={variant.payload}
@ -43,7 +48,9 @@ const FeatureVariantListItem = ({
}
/>
</TableCell>
<TableCell data-test={'VARIANT_WEIGHT'}>{variant.weight / 10.0} %</TableCell>
<TableCell data-test={'VARIANT_WEIGHT'}>
{variant.weight / 10.0} %
</TableCell>
<TableCell data-test={'VARIANT_WEIGHT_TYPE'}>
{variant.weightType === FIX ? 'Fix' : 'Variable'}
</TableCell>
@ -52,13 +59,22 @@ const FeatureVariantListItem = ({
show={
<TableCell className={styles.actions}>
<div className={styles.actionsContainer}>
<IconButton data-test={'VARIANT_EDIT_BUTTON'} onClick={() => editVariant(variant.name)}>
<IconButton
data-test={'VARIANT_EDIT_BUTTON'}
onClick={() => editVariant(variant.name)}
>
<Edit />
</IconButton>
<IconButton data-test={`VARIANT_DELETE_BUTTON_${variant.name}`} onClick={e => {
e.stopPropagation();
setDelDialog({show: true, name: variant.name });
}}>
<IconButton
data-test={`VARIANT_DELETE_BUTTON_${variant.name}`}
onClick={e => {
e.stopPropagation();
setDelDialog({
show: true,
name: variant.name,
});
}}
>
<Delete />
</IconButton>
</div>
@ -67,7 +83,6 @@ const FeatureVariantListItem = ({
elseShow={<TableCell className={styles.actions} />}
/>
</TableRow>
);
};