Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

test: remove obsolete testing pattern

Browse Source
This commit is contained in:
kwasniew 2023-12-13 08:59:58 +01:00
parent 2b7e127680
commit e68123b909
No known key found for this signature in database
GPG Key ID: 43A7CBC24C119560
2 changed files with 34 additions and 82 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
frontend/src/component/changeRequest/ChangeRequest.test.tsx
View File

@ -1,5 +1,5 @@
import { FC } from 'react'; import React, { FC } from 'react';
import { render, screen, within, fireEvent } from '@testing-library/react'; import { screen, within, fireEvent } from '@testing-library/react';
import { MemoryRouter, Routes, Route } from 'react-router-dom'; import { MemoryRouter, Routes, Route } from 'react-router-dom';
import { ThemeProvider } from 'themes/ThemeProvider'; import { ThemeProvider } from 'themes/ThemeProvider';
import { MainLayout } from 'component/layout/MainLayout/MainLayout'; import { MainLayout } from 'component/layout/MainLayout/MainLayout';
@ -9,6 +9,7 @@ import { AnnouncerProvider } from '../common/Announcer/AnnouncerProvider/Announc
import { testServerRoute, testServerSetup } from '../../utils/testServer'; import { testServerRoute, testServerSetup } from '../../utils/testServer';
import { UIProviderContainer } from '../providers/UIProvider/UIProviderContainer'; import { UIProviderContainer } from '../providers/UIProvider/UIProviderContainer';
import { StickyProvider } from 'component/common/Sticky/StickyProvider'; import { StickyProvider } from 'component/common/Sticky/StickyProvider';
import { render } from 'utils/testRenderer';
const server = testServerSetup(); const server = testServerSetup();
@ -218,33 +219,6 @@ const otherRequests = (feature: string) => {
}); });
}; };
const UnleashUiSetup: FC<{ path: string; pathTemplate: string }> = ({
children,
path,
pathTemplate,
}) => (
<UIProviderContainer>
<AccessProvider>
<MemoryRouter initialEntries={[path]}>
<ThemeProvider>
<AnnouncerProvider>
<StickyProvider>
<Routes>
<Route
path={pathTemplate}
element={
<MainLayout>{children}</MainLayout>
}
/>
</Routes>
</StickyProvider>
</AnnouncerProvider>
</ThemeProvider>
</MemoryRouter>
</AccessProvider>
</UIProviderContainer>
);
const setupHttpRoutes = ({ const setupHttpRoutes = ({
featureName, featureName,
enabled, enabled,
@ -281,12 +255,13 @@ test('add toggle change to pending change request', async () => {
setupHttpRoutes({ featureName: 'test', enabled: false }); setupHttpRoutes({ featureName: 'test', enabled: false });
render( render(
<UnleashUiSetup <Routes>
pathTemplate='/projects/:projectId/features/:featureId/*' <Route
path='/projects/default/features/test' path={'/projects/:projectId/features/:featureId/*'}
> element={<FeatureView />}
<FeatureView /> />
</UnleashUiSetup>, </Routes>,
{ route: '/projects/default/features/test' },
); );
await verifyBannerForPendingChangeRequest(); await verifyBannerForPendingChangeRequest();

71
frontend/src/component/changeRequest/ChangeRequestPermissions.test.tsx
View File

@ -1,4 +1,4 @@
import { render, screen, waitFor } from '@testing-library/react'; import { screen, waitFor } from '@testing-library/react';
import { MemoryRouter, Routes, Route } from 'react-router-dom'; import { MemoryRouter, Routes, Route } from 'react-router-dom';
import { FeatureView } from '../feature/FeatureView/FeatureView'; import { FeatureView } from '../feature/FeatureView/FeatureView';
import { ThemeProvider } from 'themes/ThemeProvider'; import { ThemeProvider } from 'themes/ThemeProvider';
@ -6,11 +6,12 @@ import { AccessProvider } from '../providers/AccessProvider/AccessProvider';
import { AnnouncerProvider } from '../common/Announcer/AnnouncerProvider/AnnouncerProvider'; import { AnnouncerProvider } from '../common/Announcer/AnnouncerProvider/AnnouncerProvider';
import { testServerRoute, testServerSetup } from '../../utils/testServer'; import { testServerRoute, testServerSetup } from '../../utils/testServer';
import { UIProviderContainer } from '../providers/UIProvider/UIProviderContainer'; import { UIProviderContainer } from '../providers/UIProvider/UIProviderContainer';
import { FC } from 'react'; import React, { FC } from 'react';
import { IPermission } from '../../interfaces/user'; import { IPermission } from '../../interfaces/user';
import { SWRConfig } from 'swr'; import { SWRConfig } from 'swr';
import { ProjectMode } from '../project/Project/hooks/useProjectEnterpriseSettingsForm'; import { ProjectMode } from '../project/Project/hooks/useProjectEnterpriseSettingsForm';
import { StickyProvider } from 'component/common/Sticky/StickyProvider'; import { StickyProvider } from 'component/common/Sticky/StickyProvider';
import { render } from 'utils/testRenderer';
const server = testServerSetup(); const server = testServerSetup();
@ -176,33 +177,6 @@ const featureEnvironments = (
}); });
}; };
const UnleashUiSetup: FC<{ path: string; pathTemplate: string }> = ({
children,
path,
pathTemplate,
}) => (
<SWRConfig value={{ provider: () => new Map() }}>
<UIProviderContainer>
<AccessProvider>
<MemoryRouter initialEntries={[path]}>
<ThemeProvider>
<AnnouncerProvider>
<StickyProvider>
<Routes>
<Route
path={pathTemplate}
element={children}
/>
</Routes>
</StickyProvider>
</AnnouncerProvider>
</ThemeProvider>
</MemoryRouter>
</AccessProvider>
</UIProviderContainer>
</SWRConfig>
);
const strategiesAreDisplayed = async ( const strategiesAreDisplayed = async (
firstStrategy: string, firstStrategy: string,
secondStrategy: string, secondStrategy: string,
@ -295,12 +269,13 @@ test('open mode + non-project member can perform basic change request actions',
setupOtherRoutes(featureName); setupOtherRoutes(featureName);
render( render(
<UnleashUiSetup <Routes>
pathTemplate='/projects/:projectId/features/:featureId/*' <Route
path={`/projects/${project}/features/${featureName}`} path={'/projects/:projectId/features/:featureId/*'}
> element={<FeatureView />}
<FeatureView /> />
</UnleashUiSetup>, </Routes>,
{ route: `/projects/${project}/features/${featureName}` },
); );
await openEnvironments(['development', 'production', 'custom']); await openEnvironments(['development', 'production', 'custom']);
@ -325,12 +300,13 @@ test('protected mode + project member can perform basic change request actions',
setupOtherRoutes(featureName); setupOtherRoutes(featureName);
render( render(
<UnleashUiSetup <Routes>
pathTemplate='/projects/:projectId/features/:featureId/*' <Route
path={`/projects/${project}/features/${featureName}`} path={'/projects/:projectId/features/:featureId/*'}
> element={<FeatureView />}
<FeatureView /> />
</UnleashUiSetup>, </Routes>,
{ route: `/projects/${project}/features/${featureName}` },
); );
await openEnvironments(['development', 'production', 'custom']); await openEnvironments(['development', 'production', 'custom']);
@ -355,12 +331,13 @@ test('protected mode + non-project member cannot perform basic change request ac
setupOtherRoutes(featureName); setupOtherRoutes(featureName);
render( render(
<UnleashUiSetup <Routes>
pathTemplate='/projects/:projectId/features/:featureId/*' <Route
path={`/projects/${project}/features/${featureName}`} path={'/projects/:projectId/features/:featureId/*'}
> element={<FeatureView />}
<FeatureView /> />
</UnleashUiSetup>, </Routes>,
{ route: `/projects/${project}/features/${featureName}` },
); );
await openEnvironments(['development', 'production', 'custom']); await openEnvironments(['development', 'production', 'custom']);