Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-19 17:52:45 +02:00
Code Issues Projects Releases Wiki Activity

fix: quick project filters total calculation (#10658)

Browse Source
This commit is contained in:
Tymoteusz Czech 2025-09-11 16:29:04 +02:00 committed by GitHub
parent 4b42435590
commit e79fa33647
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/src/component/common/LifecycleFilters/LifecycleFilters.tsx
View File

@ -66,6 +66,10 @@ export const LifecycleFilters = ({
countData, countData,
}: ILifecycleFiltersBaseProps) => { }: ILifecycleFiltersBaseProps) => {
const current = state.lifecycle?.values ?? []; const current = state.lifecycle?.values ?? [];
const allFlagsCount = Object.entries(countData ?? {}).reduce(
(acc, [key, count]) => (key !== 'archived' ? acc + count : acc),
0,
);
return ( return (
<Wrapper> <Wrapper>
@ -75,7 +79,9 @@ export const LifecycleFilters = ({
value === null value === null
? !state.lifecycle ? !state.lifecycle
: current.includes(value); : current.includes(value);
const count = value ? countData?.[value] : total; const count = value
? countData?.[value]
: allFlagsCount || undefined;
const dynamicLabel = const dynamicLabel =
isActive && Number.isInteger(total) isActive && Number.isInteger(total)
? `${label} (${total === count ? total : `${total} of ${count}`})` ? `${label} (${total === count ? total : `${total} of ${count}`})`

4
frontend/src/component/feature/FeatureToggleList/FeaturesOverviewLifecycleFilters/FeaturesOverviewLifecycleFilters.test.tsx
View File

@ -47,7 +47,7 @@ describe('LifecycleFilters', () => {
<FeaturesOverviewLifecycleFilters state={{}} onChange={vi.fn()} />, <FeaturesOverviewLifecycleFilters state={{}} onChange={vi.fn()} />,
); );
expect(getByText('All flags')).toBeInTheDocument(); expect(getByText('All flags (10)')).toBeInTheDocument();
expect(getByText('Develop (2)')).toBeInTheDocument(); expect(getByText('Develop (2)')).toBeInTheDocument();
expect(getByText('Rollout production (3)')).toBeInTheDocument(); expect(getByText('Rollout production (3)')).toBeInTheDocument();
expect(getByText('Cleanup (4)')).toBeInTheDocument(); expect(getByText('Cleanup (4)')).toBeInTheDocument();
@ -98,7 +98,7 @@ describe('LifecycleFilters', () => {
lifecycle: { operator: 'IS', values: ['completed'] }, lifecycle: { operator: 'IS', values: ['completed'] },
}); });
await userEvent.click(getByText('All flags')); await userEvent.click(getByText('All flags (10)'));
expect(onChange).toHaveBeenCalledWith({ lifecycle: null }); expect(onChange).toHaveBeenCalledWith({ lifecycle: null });
}); });
}); });