Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

fix: added stronger tag validations (#5585)

Browse Source 
Now it is impossible to filter based on invalid tag syntax.
This commit is contained in:
Jaanus Sellin 2023-12-11 13:34:51 +02:00 committed by GitHub
parent ec670450fd
commit e8f19e6341
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/lib/features/feature-search/feature.search.e2e.test.ts
View File

@ -303,6 +303,10 @@ test('should filter features by tag', async () => {
{ name: 'my_feature_c' }, { name: 'my_feature_c' },
], ],
}); });
await filterFeaturesByTag('EXCLUDE_ALL:simple', 400);
await filterFeaturesByTag('EXCLUDE_ALL:simple,simple', 400);
await filterFeaturesByTag('EXCLUDE_ALL:simple,simple:jest', 400);
}); });
test('should filter features by environment status', async () => { test('should filter features by environment status', async () => {
@ -786,9 +790,18 @@ test('should filter features by segment', async () => {
}); });
test('should search features by state with operators', async () => { test('should search features by state with operators', async () => {
await app.createFeature({ name: 'my_feature_a', stale: false }); await app.createFeature({
await app.createFeature({ name: 'my_feature_b', stale: true }); name: 'my_feature_a',
await app.createFeature({ name: 'my_feature_c', stale: true }); stale: false,
});
await app.createFeature({
name: 'my_feature_b',
stale: true,
});
await app.createFeature({
name: 'my_feature_c',
stale: true,
});
const { body } = await filterFeaturesByState('IS:active'); const { body } = await filterFeaturesByState('IS:active');
expect(body).toMatchObject({ expect(body).toMatchObject({

2
src/lib/openapi/spec/feature-search-query-parameters.ts
View File

@ -51,7 +51,7 @@ export const featureSearchQueryParameters = [
schema: { schema: {
type: 'string', type: 'string',
pattern: pattern:
'^(INCLUDE|DO_NOT_INCLUDE|INCLUDE_ALL_OF|INCLUDE_ANY_OF|EXCLUDE_IF_ANY_OF|EXCLUDE_ALL):(.*?)(,([a-zA-Z0-9_]+))*$', '^(INCLUDE|DO_NOT_INCLUDE|INCLUDE_ALL_OF|INCLUDE_ANY_OF|EXCLUDE_IF_ANY_OF|EXCLUDE_ALL):(?:\\s*[^,:]+:[^,:]+\\s*)(?:,\\s*[^,:]+:[^,:]+\\s*)*$',
example: 'INCLUDE:simple:my_tag', example: 'INCLUDE:simple:my_tag',
}, },
description: description: