Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-06-14 01:16:17 +02:00
Code Issues Projects Releases Wiki Activity

fix: now feature table does not dissapear (#8554)

Browse Source 
Feature table does not dissapear when onboarding and filter settings
hides all features
This commit is contained in:
Jaanus Sellin 2024-10-28 15:39:20 +02:00 committed by GitHub
parent 622998c62e
commit eaab9db60d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectFeatureToggles.test.tsx
View File

@ -82,8 +82,7 @@ test('selects project features', async () => {
expect(screen.queryByTestId(BATCH_SELECTED_COUNT)).not.toBeInTheDocument(); expect(screen.queryByTestId(BATCH_SELECTED_COUNT)).not.toBeInTheDocument();
}); });
// TODO: stopped working after react v18 upgrade test('filters by tag', async () => {
test.skip('filters by tag', async () => {
setupApi(); setupApi();
render( render(
<Routes> <Routes>
@ -134,8 +133,7 @@ test('filters by flag type', async () => {
await screen.findByText('Operational'); await screen.findByText('Operational');
}); });
// TODO: stopped working after react v18 upgrade test('filters by flag author', async () => {
test.skip('filters by flag author', async () => {
setupApi(); setupApi();
render( render(
<Routes> <Routes>

4
frontend/src/component/project/Project/PaginatedProjectFeatureToggles/ProjectFeatureToggles.tsx
View File

@ -134,8 +134,8 @@ export const ProjectFeatureToggles = ({
onboardingUIEnabled && onboardingUIEnabled &&
project.onboardingStatus.status !== 'onboarded' && project.onboardingStatus.status !== 'onboarded' &&
onboardingFlow === 'visible'; onboardingFlow === 'visible';
const showFeaturesTable = const noFeaturesExistInProject = project.featureTypeCounts?.length === 0;
(total !== undefined && total > 0) || notOnboarding; const showFeaturesTable = !noFeaturesExistInProject || notOnboarding;
const trackOnboardingFinish = (sdkName: string) => { const trackOnboardingFinish = (sdkName: string) => {
if (!isOnboarding) { if (!isOnboarding) {