Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-20 00:08:02 +01:00
Code Issues Projects Releases Wiki Activity

fix: Removed CR on variants flag (it's GA) (#3738)

Browse Source 
This PR removes the usage of crOnVariants flag, but keeps the behaviour,
so CR are now enabled on variants.

---------

Co-authored-by: Nuno Góis <github@nunogois.com>
This commit is contained in:
Christopher Kolstad 2023-05-10 15:46:41 +02:00 committed by GitHub
parent 73c9780bec
commit eaacb979d6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 6 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
frontend/src/component/feature/FeatureView/FeatureVariants/FeatureEnvironmentVariants/EnvironmentVariantsModal/EnvironmentVariantsModal.tsx
View File

@ -269,9 +269,7 @@ export const EnvironmentVariantsModal = ({
? 'Add to existing change request'
: 'Add change to draft';
const isChangeRequest =
isChangeRequestConfigured(environment?.name || '') &&
uiConfig.flags.crOnVariants;
const isChangeRequest = isChangeRequestConfigured(environment?.name || '');
const stickiness = useMemo(() => {
if (!loading) {

6
frontend/src/component/feature/FeatureView/FeatureVariants/FeatureEnvironmentVariants/FeatureEnvironmentVariants.tsx
View File

@ -69,11 +69,9 @@ export const FeatureEnvironmentVariants = () => {
() =>
feature?.environments?.map(environment => ({
...environment,
crEnabled:
uiConfig.flags.crOnVariants &&
isChangeRequestConfigured(environment.name),
crEnabled: isChangeRequestConfigured(environment.name),
})) || [],
[feature.environments, uiConfig.flags.crOnVariants]
[feature.environments]
);
const createPatch = (

1
frontend/src/interfaces/uiConfig.ts
View File

@ -41,7 +41,6 @@ export interface IFlags {
messageBanner?: boolean;
featuresExportImport?: boolean;
caseInsensitiveInOperators?: boolean;
crOnVariants?: boolean;
proPlanAutoCharge?: boolean;
notifications?: boolean;
personalAccessTokensKillSwitch?: boolean;

2
src/lib/__snapshots__/create-config.test.ts.snap
View File

@ -69,7 +69,6 @@ exports[`should create default config 1`] = `
"anonymiseEventLog": false,
"caseInsensitiveInOperators": false,
"cleanClientApi": false,
"crOnVariants": false,
"demo": false,
"embedProxy": true,
"embedProxyFrontend": true,
@ -92,7 +91,6 @@ exports[`should create default config 1`] = `
"anonymiseEventLog": false,
"caseInsensitiveInOperators": false,
"cleanClientApi": false,
"crOnVariants": false,
"demo": false,
"embedProxy": true,
"embedProxyFrontend": true,

14
src/lib/services/feature-toggle-service.ts
View File

@ -1737,13 +1737,7 @@ class FeatureToggleService {
user: User,
oldVariants?: IVariant[],
): Promise<IVariant[]> {
if (this.flagResolver.isEnabled('crOnVariants')) {
await this.stopWhenChangeRequestsEnabled(
projectId,
environment,
user,
);
}
await this.stopWhenChangeRequestsEnabled(projectId, environment, user);
return this.saveVariantsOnEnv(
projectId,
featureName,
@ -1761,10 +1755,8 @@ class FeatureToggleService {
newVariants: IVariant[],
user: User,
): Promise<IVariant[]> {
if (this.flagResolver.isEnabled('crOnVariants')) {
for (const env of environments) {
await this.stopWhenChangeRequestsEnabled(projectId, env);
}
for (const env of environments) {
await this.stopWhenChangeRequestsEnabled(projectId, env);
}
return this.setVariantsOnEnvs(
projectId,

4
src/lib/types/experimental.ts
View File

@ -33,10 +33,6 @@ const flags = {
process.env.UNLEASH_EXPERIMENTAL_CASE_INSENSITIVE_IN_OPERATORS,
false,
),
crOnVariants: parseEnvVarBoolean(
process.env.UNLEASH_EXPERIMENTAL_CR_ON_VARIANTS,
false,
),
strictSchemaValidation: parseEnvVarBoolean(
process.env.UNLEASH_STRICT_SCHEMA_VALIDTION,
false,