From eae7535bfc4ada674b30fbab591c883e05eead5b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gast=C3=B3n=20Fournier?= Date: Mon, 31 Mar 2025 14:33:38 +0200 Subject: [PATCH] feat: remove access overview flag making it GA ready (#9654) This is exposing information we already have about permissions in a UI that should help users have an overview of the permissions of a user with regards to projects and environments --- .../component/admin/users/UsersList/UsersList.tsx | 15 ++++----------- frontend/src/interfaces/uiConfig.ts | 1 - src/lib/types/experimental.ts | 5 ----- src/server-dev.ts | 1 - 4 files changed, 4 insertions(+), 18 deletions(-) diff --git a/frontend/src/component/admin/users/UsersList/UsersList.tsx b/frontend/src/component/admin/users/UsersList/UsersList.tsx index a92d081ee5..7ba21ea98d 100644 --- a/frontend/src/component/admin/users/UsersList/UsersList.tsx +++ b/frontend/src/component/admin/users/UsersList/UsersList.tsx @@ -58,7 +58,6 @@ const UsersList = () => { }>({ open: false, }); - const userAccessUIEnabled = useUiFlag('userAccessUIEnabled'); const showUserDeviceCount = useUiFlag('showUserDeviceCount'); const showSSOUpgrade = isOss() && users.length > 3; @@ -218,15 +217,9 @@ const UsersList = () => { onEdit={() => { navigate(`/admin/users/${user.id}/edit`); }} - onViewAccess={ - userAccessUIEnabled - ? () => { - navigate( - `/admin/users/${user.id}/access`, - ); - } - : undefined - } + onViewAccess={() => { + navigate(`/admin/users/${user.id}/access`); + }} onChangePassword={openPwDialog(user)} onResetPassword={openResetPwDialog(user)} onDelete={openDelDialog(user)} @@ -250,7 +243,7 @@ const UsersList = () => { searchable: true, }, ], - [roles, navigate, isBillingUsers, userAccessUIEnabled], + [roles, navigate, isBillingUsers], ); const initialState = useMemo(() => { diff --git a/frontend/src/interfaces/uiConfig.ts b/frontend/src/interfaces/uiConfig.ts index 4560c28f32..6dfd540136 100644 --- a/frontend/src/interfaces/uiConfig.ts +++ b/frontend/src/interfaces/uiConfig.ts @@ -74,7 +74,6 @@ export type UiFlags = { feedbackComments?: Variant; showInactiveUsers?: boolean; feedbackPosting?: boolean; - userAccessUIEnabled?: boolean; outdatedSdksBanner?: boolean; estimateTrafficDataCost?: boolean; disableShowContextFieldSelectionValues?: boolean; diff --git a/src/lib/types/experimental.ts b/src/lib/types/experimental.ts index 5379c178cd..93dde407db 100644 --- a/src/lib/types/experimental.ts +++ b/src/lib/types/experimental.ts @@ -36,7 +36,6 @@ export type IFlagKey = | 'estimateTrafficDataCost' | 'useMemoizedActiveTokens' | 'queryMissingTokens' - | 'userAccessUIEnabled' | 'disableUpdateMaxRevisionId' | 'disablePublishUnannouncedEvents' | 'outdatedSdksBanner' @@ -197,10 +196,6 @@ const flags: IFlags = { process.env.UNLEASH_EXPERIMENTAL_ESTIMATE_TRAFFIC_DATA_COST, false, ), - userAccessUIEnabled: parseEnvVarBoolean( - process.env.UNLEASH_EXPERIMENTAL_USER_ACCESS_UI_ENABLED, - false, - ), disableUpdateMaxRevisionId: parseEnvVarBoolean( process.env.UNLEASH_EXPERIMENTAL_DISABLE_SCHEDULED_CACHES, false, diff --git a/src/server-dev.ts b/src/server-dev.ts index dbbd6ffeb2..a877fbc321 100644 --- a/src/server-dev.ts +++ b/src/server-dev.ts @@ -40,7 +40,6 @@ process.nextTick(async () => { embedProxyFrontend: true, anonymiseEventLog: false, responseTimeWithAppNameKillSwitch: false, - userAccessUIEnabled: true, outdatedSdksBanner: true, disableShowContextFieldSelectionValues: false, feedbackPosting: true,