Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-20 00:08:02 +01:00
Code Issues Projects Releases Wiki Activity

fix: variant table deadlocks (#4309)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2023-07-21 11:34:32 +02:00 committed by GitHub
parent 512b8a41ed
commit eaf002ff7a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/lib/db/client-metrics-store-v2.ts
View File

@ -179,11 +179,21 @@ export class ClientMetricsStoreV2 implements IClientMetricsStoreV2 {
await this.db.raw(query); await this.db.raw(query);
const variantRows = spreadVariants(metrics).map(toVariantRow); const variantRows = spreadVariants(metrics).map(toVariantRow);
if (variantRows.length > 0) {
// Sort the rows to avoid deadlocks
const sortedVariantRows = variantRows.sort(
(a, b) =>
a.feature_name.localeCompare(b.feature_name) ||
a.app_name.localeCompare(b.app_name) ||
a.environment.localeCompare(b.environment) ||
a.variant.localeCompare(b.variant),
);
if (sortedVariantRows.length > 0) {
const insertVariants = this.db<ClientMetricsEnvVariantTable>( const insertVariants = this.db<ClientMetricsEnvVariantTable>(
TABLE_VARIANTS, TABLE_VARIANTS,
) )
.insert(variantRows) .insert(sortedVariantRows)
.toQuery(); .toQuery();
const variantsQuery = `${insertVariants.toString()} ON CONFLICT (feature_name, app_name, environment, timestamp, variant) DO UPDATE SET "count" = "client_metrics_env_variants"."count" + EXCLUDED.count`; const variantsQuery = `${insertVariants.toString()} ON CONFLICT (feature_name, app_name, environment, timestamp, variant) DO UPDATE SET "count" = "client_metrics_env_variants"."count" + EXCLUDED.count`;
await this.db.raw(variantsQuery); await this.db.raw(variantsQuery);