Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
Code Issues Projects Releases Wiki Activity

Clean up intervals.

Browse Source 
We use intervals in three places and we could probably organise them
better in the future. As long as they all do unref they do not form
any issues for us and I will just let them be as is for now.

This closes #186
This commit is contained in:
Ivar 2017-09-07 22:52:24 +02:00 committed by Ivar Conradi Østhus
parent 54ca4ffc77
commit eb346756d2
2 changed files with 10 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/db/client-instance-store.js
View File

@ -12,6 +12,8 @@ const COLUMNS = [
];
const TABLE = 'client_instances';
const ONE_DAY = 24 * 61 * 60 * 1000;
const mapRow = row => ({
appName: row.app_name,
instanceId: row.instance_id,
@ -21,19 +23,12 @@ const mapRow = row => ({
createdAt: row.created_at,
});
// const mapAppsRow = (row) => ({
// appName: row.app_name,
// createdAt: row.created_at,
// });
class ClientInstanceStore {
constructor(db) {
this.db = db;
setTimeout(() => this._removeInstancesOlderThanTwoDays(), 10).unref();
setInterval(
() => this._removeInstancesOlderThanTwoDays(),
24 * 61 * 60 * 1000
).unref();
const clearer = () => this._removeInstancesOlderThanTwoDays();
setTimeout(clearer, 10).unref();
setInterval(clearer, ONE_DAY).unref();
}
_removeInstancesOlderThanTwoDays() {

10
lib/db/client-metrics-db.js
View File

@ -5,6 +5,8 @@ const logger = require('../logger')('client-metrics-db.js');
const METRICS_COLUMNS = ['id', 'created_at', 'metrics'];
const TABLE = 'client_metrics';
const ONE_MINUTE = 60 * 1000;
const mapRow = row => ({
id: row.id,
createdAt: row.created_at,
@ -16,11 +18,9 @@ class ClientMetricsDb {
this.db = db;
// Clear old metrics regulary
setTimeout(() => this.removeMetricsOlderThanOneHour(), 10).unref();
setInterval(
() => this.removeMetricsOlderThanOneHour(),
60 * 1000
).unref();
const clearer = () => this.removeMetricsOlderThanOneHour();
setTimeout(clearer, 10).unref();
setInterval(clearer, ONE_MINUTE).unref();
}
removeMetricsOlderThanOneHour() {