Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-20 00:08:02 +01:00
Code Issues Projects Releases Wiki Activity

fix: remove tooltip from favorites cell, some refactoring (#2687)

Browse Source 
https://linear.app/unleash/issue/2-510/favorite-cell-tooltips-is-buggy-when-pinned-remove-tooltips

Tooltips were buggy when using the pinned feature, so I aligned with
@NicolaeUnleash and decided to remove them for now:
<img width="407" alt="image"
src="https://user-images.githubusercontent.com/14320932/207380515-476a4bec-c1c0-43af-adb8-f7001ae75e9c.png">

Also includes a slight refactor on this component.
This commit is contained in:
Nuno Góis 2022-12-14 08:51:41 +00:00 committed by GitHub
parent 212083b5ed
commit eb433185a1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 27 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
frontend/src/component/common/Table/cells/FavoriteIconCell/FavoriteIconCell.tsx
View File

@ -5,49 +5,46 @@ import {
StarBorder as StarBorderIcon,
} from '@mui/icons-material';
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
import { TooltipResolver } from 'component/common/TooltipResolver/TooltipResolver';
const StyledCell = styled(Box)(({ theme }) => ({
paddingLeft: theme.spacing(1.25),
}));
const StyledIconButton = styled(IconButton)(({ theme }) => ({
color: theme.palette.primary.main,
padding: theme.spacing(1.25),
}));
const StyledIconButtonInactive = styled(StyledIconButton)({
opacity: 0,
});
interface IFavoriteIconCellProps {
value?: boolean;
onClick?: () => void;
}
const InactiveIconButton = styled(IconButton)(({ theme }) => ({
color: theme.palette.primary.main,
opacity: 0,
}));
export const FavoriteIconCell: VFC<IFavoriteIconCellProps> = ({
value = false,
value,
onClick,
}) => (
<Box sx={{ pl: 1.25, display: 'inline-flex' }}>
<StyledCell>
<ConditionallyRender
condition={value}
condition={Boolean(value)}
show={
<TooltipResolver title={'Remove from favorites'}>
<IconButton
onClick={onClick}
color="primary"
size="small"
sx={{ padding: 1.25 }}
>
<StarIcon fontSize="small" />
</IconButton>
</TooltipResolver>
<StyledIconButton onClick={onClick} size="small">
<StarIcon fontSize="small" />
</StyledIconButton>
}
elseShow={
<TooltipResolver title={'Add to favorites'}>
<InactiveIconButton
className="show-row-hover"
onClick={onClick}
size="small"
sx={{ padding: 1.25 }}
>
<StarBorderIcon fontSize="small" />
</InactiveIconButton>
</TooltipResolver>
<StyledIconButtonInactive
className="show-row-hover"
onClick={onClick}
size="small"
>
<StarBorderIcon fontSize="small" />
</StyledIconButtonInactive>
}
/>
</Box>
</StyledCell>
);